From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id AF60C5CE1AB; Tue, 29 Aug 2023 17:48:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AF60C5CE1AB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1693320522; bh=kfIcwPgxVhnvQf3nxG2hVhESBGUow6ebod1lpPD+IMM=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=CJaDnIOAjsEKBPmyP1xGd/KdWoyDSNYoh/lwUq/0aQVs3tIQ8MFAdY8vQ9+NDDm/G aeJluAS0hDgf9PmhwhW5Pejqq+ZlSGIxa3889YXzJBP4CeKzYO6sppHR+2KQBPnFiV aONS8udkWvXk83nqKHk93jdtopkPB54xy8sFD5ag= Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [95.163.41.87]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EDCBB5CB3A6 for ; Tue, 29 Aug 2023 17:48:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EDCBB5CB3A6 Received: by smtp51.i.mail.ru with esmtpa (envelope-from ) id 1qb01H-009Mss-2n; Tue, 29 Aug 2023 17:48:40 +0300 Date: Tue, 29 Aug 2023 17:43:56 +0300 To: Sergey Bronnikov Cc: Sergey Bronnikov , tarantool-patches@dev.tarantool.org, max.kokryashkin@gmail.com Message-ID: References: <8b2d744f68eb138c2b2c37e1ac851181e303b485.1693305720.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9AE2E1BB6058F4E36E91185B2867022B7B578AF9794E549BB182A05F538085040A5A519F1600AEFF773791703F03F1F5BCF0423E6AD2245AD24BB0DAB7B9EA850 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7965AF5021CACFC74C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7AA1605287C7F04D6EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BE5CCB53A13BC8DBACEDBF6FACB59A708C895534AC64D5A1FCC7F00164DA146DAFE8445B8C89999728AA50765F79006379BABF3D50D9A3D87389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC821E93C0F2A571C7BF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CD56D36E97F3F038C040F9FF01DFDA4A84AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3856009BA58C5E1BBBA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7BEE702378D8A34C7731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5F418BA527E9B4C924F16B399E21903FFCC8C7CF9C121AC2DF87CCE6106E1FC07E67D4AC08A07B9B02A336C6518635091CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3438212F20E1E78D8E78FB3E56850655D05FF0C8933F5726C0193028EA9DB5778C451182CFA66DE83A1D7E09C32AA3244CC8A874247C899204ED542AB0A00E65D94DBEAD0ED6C55A80BAD658CF5C8AB4025DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojA5xtch+oMC59/ojGtYInfg== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A7696D0D3571C16ED6C873791703F03F1F5B5F9045B74F665CC8DEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix predict_next() in parser (again). X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the updates! LGTM, after fixing several minor comments below. On 29.08.23, Sergey Bronnikov wrote: > Hi, Sergey > > thanks for review! See my comments. > > New changes were force-pushed. > > > On 8/29/23 16:38, Sergey Kaplun wrote: > > Hi, Sergey! > > Thanks for the patch! > > Please consider my comments below. > > > > On 29.08.23, Sergey Bronnikov wrote: > >> From:sergeyb@tarantool.org > >> > >> In a function `predict_next` variable `exprpc` looks forward and expects > > Minor: I suggest using of `()` for distinguishing function and variable > > names. > > Feel free to ignore. > > Fixed. However "function" was before "predict_next". > Yes, I understand, its just matter of taste :). > >> Sergey Bronnikov: > >> * added the description and the test for the problem > >> > >> Part of tarantool/tarantool#8825 > >> --- > >> > >> PR:https://github.com/tarantool/tarantool/pull/9054 > >> Branch:https://github.com/tarantool/luajit/tree/ligurio/lj-1054-incorrect-pc-value-predict_next > >> Related issue: > >> *https://github.com/LuaJIT/LuaJIT/issues/1054 > >> > >> src/lj_parse.c | 4 +++- > >> ...incorrect-pc-value-in-predict_next.test.lua | 18 ++++++++++++++++++ I suggest to use predict-next instead in filename and testname to be consistent with other tests. > >> 2 files changed, 21 insertions(+), 1 deletion(-) > >> create mode 100644 test/tarantool-tests/lj-1054-incorrect-pc-value-in-predict_next.test.lua > >> > > > >> +-- Sample executed in LuaJIT instrumented by ASAN leads to > >> +-- a heap-buffer-overflow. > > Minor: IDK why, but suggested varian here is "heap buffer overflow". > > > ASAN reports error with hyphens, like this: > > |==90673==ERROR: AddressSanitizer: heap-buffer-overflow on address > 0x6020000000fb at pc 0x000108868a95 bp 0x7fff573979a0 sp 0x7fff57397998 > READ of size 1 at 0x6020000000fb thread T0| > > If you don't like variant "heap-buffer-overflow" then we can use variant > used in CWE list: "heap-based buffer overflow", see [1]. > > What variant should > > 1. https://cwe.mitre.org/data/definitions/122.html Yes, lets used it. > > > > >> +-- See alsohttps://github.com/LuaJIT/LuaJIT/issues/528 Nit: Missed dot at the end of the sentence. Typo: s/528/1054./ -- Best regards, Sergey Kaplun