From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E82B7580F72; Wed, 16 Aug 2023 18:37:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E82B7580F72 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692200253; bh=iSRweDNpme5hdtvtF4VcPwTjV84q+EE/G8LrK16/mBg=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=cGctrSrh3FrizzwXdE3hDB3GfooROUwdu4J83IU6kNzvd82WtjhJoliPDR04hW/No maAOVnL0pR5mjACmgXvZmrl0s+eaj7IVGxguEDYdfNM7gjD+/HpvEj9IGQJdGDWYsF DFrdgfZlLXjbukztLr9Wo5ptscsried0houn/72g= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A8C5D580F72 for ; Wed, 16 Aug 2023 18:37:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A8C5D580F72 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1qWIaQ-0004af-OM; Wed, 16 Aug 2023 18:37:31 +0300 Date: Wed, 16 Aug 2023 18:32:43 +0300 To: Sergey Bronnikov Message-ID: References: <7179245cf38c56a88bb8f3aa1bbeaf15402fcd1a.1691592488.git.skaplun@tarantool.org> <7025f893-d2b0-2e78-faf4-22a98bdb7b3b@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7025f893-d2b0-2e78-faf4-22a98bdb7b3b@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9700E0DCE2907754D4FC677755C812E332EA741D6A7864909182A05F5380850409250A76F03976A4B5E5C390497D28661288EACEE2D2A93A730B148DE62422A08 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77603ADE015AF816DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063748744D4CD6EC491D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D835073B76B2F790D444A47174E4540BC7117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF070A1BC70AFFF2BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8B8C7ADC89C2F0B2A5AAAE862A0553A39223F8577A6DFFEA7CC1948A84299AD5C643847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A515D8B7F5F6AD97B534F5B664BAD97BED277BD8F3D1FE93E3F87CCE6106E1FC07E67D4AC08A07B9B00A6B3CD6EB70C818BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D340297C696F996E384FA30620BB51F2B73061FAE24A90F9794B682057B971BAEDA84A1E2CF9C39518F1D7E09C32AA3244C18B0A211F15ABD9062486A7287CE4192853296C06374E602BAD658CF5C8AB4025DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojFRrmMqSMPxr8e8N7qSNQSg== X-DA7885C5: ABCFFF6B8E5D45B63571C21B129FB87D7728ECBD40F3D8E0EA0182433F050388262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986BBD7756C99F3C68E9B20F0A149DE4FDB70FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 03/19] MIPS: Fix handling of spare long-range jump slots. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! On 16.08.23, Sergey Bronnikov wrote: > Hi, Sergey > > > thanks for the patch! > > Test has passed after reverting a patch and I suspect it is expected because > > behaviour was broken for MIPS only, right? Yes, its true. > > See a minor comment below. > > > On 8/9/23 18:35, Sergey Kaplun wrote: > > From: Mike Pall > > > > Contributed by Djordje Kovacevic and Stefan Pejic. > > > > (cherry-picked from commit c7c3c4da432ddb543d4b0a9abbb245f11b26afd0) > > > > `asm_setup_jump()` in presumes that `sizeof(MCLink)` > > is 8 bytes, but for MIPS64 its size is 16 bytes. This leads to incorrect > > check in `asm_sparejump_setup()`, so mcode bottom is not updated. > > > > This patch fixes check of the MCLink offset from the mcbot. > > Nevertheless, the emitting of spare jump slots is still incorrect, so > > the introduced test still fails due to incorrect iteration through the > > sparce table (the last slot is out of mcode range). > "sparce" -> "sparse"? Changed to the "spare slots". > -- Best regards, Sergey Kaplun