From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0E359581218; Wed, 16 Aug 2023 18:29:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0E359581218 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692199788; bh=RO2IPxzDG87MR/UginuPyThZ5DWVCvXJ+ldp+M//sjg=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=BNnG2ARBSuoMxA+Ecw3cGBvkW5ZsZ1/CzFQW+IyO7Yn+Y4XOn1jlKwZ9Dwza5rxEZ 2iU9+3SwJpkFC/LD3DpL9E2ECCZpPHN+w3jZEaiwDCNKNCnXGmYJWn9Ella9m8Hfg/ veS5UCFqxBrzYdZZ/oLitUtQCWIHKLE8BhT/enro= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6EF12580F72 for ; Wed, 16 Aug 2023 18:29:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6EF12580F72 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1qWISv-0005ms-Hg; Wed, 16 Aug 2023 18:29:46 +0300 Date: Wed, 16 Aug 2023 18:24:58 +0300 To: Maxim Kokryashkin Message-ID: References: <876736e650dcb70ce32a272f92cc3ba034a4dd3b.1691592488.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9700E0DCE2907754DD1BE1B13E5F9E0E702D280D9A56F9A40182A05F538085040ABE6496FCA1E80A4A92A498BDBB00C69C8B80B45FFCA34C6B552425A618E1AC2 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7E50EC9128971FD6EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CFA2FDEB3954FDBC8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8BBA094FA9BA8AACCD2C71915B3A3C223117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC4AFB60FD1831C04CA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FC26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BAE9A1BBD95851C5BAAAE862A0553A39223F8577A6DFFEA7CC1948A84299AD5C643847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5C047746C86DCAC3CA93A76904626D7BAD5F016B25C677F16F87CCE6106E1FC07E67D4AC08A07B9B06A1CB4668A9CA5FACB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D349320586B19AD2C72E2335D7F1BEAE5E2B03635DBDC917590CBC23607F4D2B778C91BBD4E88E344411D7E09C32AA3244CB6EF7924A827AD6E97AAD8BBD9C2559C7C0C08F7987826B9BAD658CF5C8AB4025DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojHVl7ekwB6hic8Z75NPgm7w== X-DA7885C5: 58783B4BC3691E44E9EB69E243218904DE8737A3F3759CA3E54B7C20D81BCC81262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B5017294D40E4A32F5EC0DB432A52B1750FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 19/19] MIPS: Add MIPS64 R6 port. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! Fixed your comments inline. On 16.08.23, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, except for a few nits regarding the commit message. > On Wed, Aug 09, 2023 at 06:36:08PM +0300, Sergey Kaplun via Tarantool-patches wrote: > > From: Mike Pall > > > > Contributed by Hua Zhang, YunQiang Su from Wave Computing, > > and Radovan Birdic from RT-RK. > > Sponsored by Wave Computing. > > > > (cherry-picked from commit 94d0b53004a5fa368defa4307a17edcdb87fe727) > > > > This patch adds support for MIPS Release 6 [1] for the 64-bit build. > > This includes: > > * Global `_map_def` value is set with . `MIPSR6` key > > specifies the corresponding instruction set support. Also, `MIPSR6` is > > defined in `DYNASM_FLAGS` (`DASM_AFLAGS`). > > * New instructions are added within , they are > > used if the aforementioned key is set. > > * Obsolete instructions (that are no more in use in r6) are used in the > Typo: s/no more/no longer/ Fixed. > > opposite case (if `MIPSR6` isn't set). > > * New opcode maps are added into . > Typo: s/into/to/ Fixed. > > * `map_arch` table in is refactored for more convenient > > usage. Now each arch key contains a table with the corresponding info > > about supported architecture: > Typo: s/about/about the/ Fixed. > > - `e`: endianess; "le" or "be" > > - `b`: bit-width of the supported architecture; 32 or 64 > > - `m`: machine specification (see `e_machine` in man elf) > > - `f`: processor-specific flags (see `e_flags` in man elf) > > - `p`: number that identifies the type of target machine [2] for > > Portable Executable format [3]. > > * New `LJ_TARGET_MIPSR6` define is set for MIPSR6 in . > > * The corresponding "MIPS32R6", "MIPS64R6" CPU strings are added to the > > > > * MIPSR6 instructions are added to the , some > > obsolete instructions are removed or defined only for the non-MIPSR6 > > build. > > * All release-dependent instructions in are > > instrumented with `LJ_TARGET_MIPSR6` macro. > > * `f20`, `f21`, `f22` FP registers are defined as `FTMP0`, `FTMP1`, > > `FTMP2` correspondingly in the VM. > > * All release-dependent instructions in are > > instrumented with `MIPSR6` macro. > > * `sfmin_max` macro now takes the third operand for the MIPSR6 build. > > * Fix implicit fallthrough warning for `LJ_SOFTFP && !LJ_NEED_FP64` > Typo: s/Fix/Fix the/ Fixed. > > build in . > > > > Note, that 32-bit r6 targets still unsupported, because it is difficult > Typo: s/targets/targets are/ Fixed. > > and most available r6 CPUs are 64 bit. > > > > [1]: https://www.mips.com/products/architectures/mips64/ > > [2]: https://learn.microsoft.com/en-us/windows/win32/debug/pe-format#machine-types > > [3]: https://learn.microsoft.com/en-us/windows/win32/debug/pe-format > > > > Sergey Kaplun: > > * added the description for the feature > > > > Part of tarantool/tarantool#8825 > > --- > > -- Best regards, Sergey Kaplun