From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 807AC581214; Wed, 16 Aug 2023 18:27:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 807AC581214 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692199642; bh=lYTUovANoCRmcIfBst6xMvC7kaFaM29DwyKzKNmEl/k=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=U+pJ0AQeovrgVUA+P6T2SDODhwVIFyBOeorybHsBl0ifUG3IXSmwUc7XL/18jNXXE X94Uzms09gxW49dCEKHzMxSpMt21+R77EhFdLH3KYSNQ1ilv+Ycs4yoCGifdW7kEKm H69YQTjS1JKFjxkATrx54Qkz+bxbVjgJjqeEUWYs= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5F5F0580F72 for ; Wed, 16 Aug 2023 18:27:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5F5F0580F72 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1qWIQa-0004xI-HM; Wed, 16 Aug 2023 18:27:20 +0300 Date: Wed, 16 Aug 2023 18:22:31 +0300 To: Maxim Kokryashkin Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD93AA62145E837FE28E96D0DBF739299FC3DB55B78047F7EFC182A05F5380850404C228DA9ACA6FE27B68E841D1A3788960FBED6706EBEF5B8C50D213BB9175719BB6070CB08FF1D37 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE721B3E54BB37EA0B4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063764BF1E09E94CC6278638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8F137EF1653496B770747BF67FC069C1E117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC79B25E177BEFA2CBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD186FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8B974A882099E279BDAAAE862A0553A39223F8577A6DFFEA7CC1948A84299AD5C643847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5A3C7E7F5B759974C692675FB8950C541A53E72E27EB7B832F87CCE6106E1FC07E67D4AC08A07B9B0E753FA5741D1AD02CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34951738D4D62E58A4C57D97C959BDAEDB9A640C41CDED567B90961C1350E492221789B3983FFB7F8B1D7E09C32AA3244C341939855EBB66BDD27F272031222E7F853296C06374E602BAD658CF5C8AB4025DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojHVl7ekwB6hiTq0MWZWOcVA== X-DA7885C5: 498435E330014FC04E13955197A1174A074D6FB86962D2AF9158AEB8C9C6DCB8262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B52624BC3EB74C9386B8903BB6BCF26450FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 18/19] DynASM/MIPS: Fix shadowed variable. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! On 16.08.23, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, except for the single typo in the commit message. > On Wed, Aug 09, 2023 at 06:36:07PM +0300, Sergey Kaplun via Tarantool-patches wrote: > > From: Mike Pall > > > > Cleanup only, bug cannot trigger. > > Thanks to Domingo Alvarez Duarte. > > > > (cherry-picked from commit 5c911998a3c85d024a8006feafc68d0b4c962fd8) > > > > This patch fixes local shadow variable `n` in `template__` function from > Typo: s/local/the local/ Fixed, thanks! > > by renaming it to `m`. Since this cannot be > > triggered, there is no test provided. > > > > Sergey Kaplun: > > * added the description for the problem > > --- > > 2.41.0 > > -- Best regards, Sergey Kaplun