From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5823A580F48; Wed, 16 Aug 2023 17:27:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5823A580F48 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692196056; bh=ELZxRz2qtD7wb+R3/5N48mPPfCj3QQw6TeHlgeDDL7I=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=jo29zG/OlfSGuV8SsRXOIdEvpWB0nG1YOKk8LnRInmKMWJ03UmFWaRxu9q/5cYZbU +pUFx6/VZqSHw8IW7DN6Zmmo8uJhxF94J/3lFN2Io/wGoCeXLwTVrDyMHbe0kgOJ5U slgEYvJNN1w2JaJzD29OgJPjvEpTFBIXUWXDBl6I= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 25D7B532601 for ; Wed, 16 Aug 2023 17:27:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 25D7B532601 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1qWHUk-0000WO-6Y; Wed, 16 Aug 2023 17:27:34 +0300 Date: Wed, 16 Aug 2023 17:22:46 +0300 To: Maxim Kokryashkin Message-ID: References: <6n7ziyckasjdkbhbvba3v7gpzchvbfi2fl5dn5jsoa3vtwltet@atywztqnppsv> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6n7ziyckasjdkbhbvba3v7gpzchvbfi2fl5dn5jsoa3vtwltet@atywztqnppsv> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9700E0DCE2907754DD1BE1B13E5F9E0E702D280D9A56F9A40182A05F5380850407369EE9D74D567A50DC70ED1D2ED8CA21AF606D78DB5A6B8740AB6523A7961EF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76C0A440987CA342DC2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE736691C7D10565E038F08D7030A58E5AD1A62830130A00468AEEEE3FBA3A834EE7353EFBB5533756678899A6EE82F594EF4CD91DB4B4C15CD1147B4DD3FA144B0A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE764DB9FC91078681A9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3E478A468B35FE767117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407978DA827A17800CE7FCEEFFE83360B3FE2DBA43225CD8A89F616AD31D0D18CD5C262FEC7FBD7D1F5BB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5E796AA54A067776161E6A7E167C12CA1F578DAD50DEA82F4F87CCE6106E1FC07E67D4AC08A07B9B0DB8A315C1FF4794DBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34738A88CA0C70A558423002BEDD53013E3C88219AFDAE923A77371699A7070ADCB55B6D54FE0E3C861D7E09C32AA3244CEC68C0ADFE7F475EF92C365866F26D079CA7333006C390A0BAD658CF5C8AB4025DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojHVl7ekwB6hhzx0WA6GZbcQ== X-DA7885C5: 3FFDC635B970453439CEA0B749E66C2B8786BCD274DBC257D2CB53F59153C1FF262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986BF12354167E62BE1097B135B831028F010FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 15/19] Fix LJ_MAX_JSLOTS assertion in rec_check_slots(). X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! Fixed your comments inline. On 15.08.23, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, except for a few comments below. > On Wed, Aug 09, 2023 at 06:36:04PM +0300, Sergey Kaplun via Tarantool-patches wrote: > > From: Mike Pall > > > > Thanks to Yichun Zhang. > > > > (cherry-picked from commit 1c89933f129dde76944336c6bfd05297b8d67730) > > > > This patch is predecessor for the commit > Typo: s/is predecessor for the/is the predecessor to/ Fixed. > > 944d32afd6ddd9dbac1cddf64bf81333efeb9e30 ("Add missing LJ_MAX_JSLOTS > > check.") It tries to fix the issue, when `J->baseslot == LJ_MAX_JSLOTS`, > > that leading to the assertion failure. Since the predecessor patch, > Typo: s/leading/leads/ Fixed, thanks! > > there are no places, that can lead to the condition failure, since we > > always check that new baseslot + framesize (+ vargframe) >= > > `LJ_MAX_JSLOTS`. As far as minimum framesize is 1 (see > Typo: s/as minimum/as the minimum/ Fixed. > > for details), we can't obtain this assertion failure. This patch is > > added for the consistency with the upstream. > Typo: s/the consistency/consistency/ Fixed. > > > > Since the predecessor patch fixes the issue, there is no new test case > > to add. > > > > Sergey Kaplun: > > * added the description for the problem > > > > Part of tarantool/tarantool#8825 > > --- > > src/lj_record.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/src/lj_record.c b/src/lj_record.c > > index 02d9db9e..6030f77c 100644 > > --- a/src/lj_record.c > > +++ b/src/lj_record.c > > -- > > 2.41.0 > > -- Best regards, Sergey Kaplun