From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9E469532601; Wed, 16 Aug 2023 17:12:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9E469532601 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692195175; bh=IC+ny4BvrRqCfZnO2wfvt5kmZWCeLOK6XLWgQo0lRrE=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=VdETYkfE5F7tKiREtfJAFueP5J0LkqAa9odY5/UyybKuhVgjxP1rLerdIJEMdSCaN UnfmHHxDKb3+f3Ao6/CPDhQlFNCFjC0vpZx9VEvVMMb4nF2BCKuR8naCwkMgrD8/Bf G7+xC7SOV4vQuJfB2YliZysqLx0+22L2aHdmxHnM= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EEC73532601 for ; Wed, 16 Aug 2023 17:12:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EEC73532601 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1qWHGX-0003Sc-1P; Wed, 16 Aug 2023 17:12:53 +0300 Date: Wed, 16 Aug 2023 17:08:05 +0300 To: Maxim Kokryashkin Message-ID: References: <3166f89d23b9986f3849f2873ee78285c034b894.1691592488.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9700E0DCE2907754D6BBDFD16DC5F73F29F7DA2AE4136AA2D182A05F538085040CC2C61A8537779FC82E1D4C705D212CBA25000C332801602A7BE1018D0C4AD1E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FEAC828D2BF6EC3CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063748C26B83F2B024408638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D891D33F2FAEF2E3A4AFA3731F4A127A10117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCECD08F8D939B2CE4A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8B3A703B70628EAD7BAAAE862A0553A39223F8577A6DFFEA7C741622C43FECC0DC43847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5B7D2642C213835D82668568779A1C1ADD0C3FCDD67FD83D9F87CCE6106E1FC07E67D4AC08A07B9B00A6B3CD6EB70C818BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF7D159751844EE67D5732151FFC18DD0AC87DC78A91453C85BED74400ED8481A017C141E43CE0FC0B24F7434E9608BF9F2983E4C2CDA3335FD75062D82BE5CE80A74DFFEFA5DC0E7F02C26D483E81D6BE5EF9655DD6DEA7D65774BB76CC95456EEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojHVl7ekwB6hi2hsViGDapww== X-DA7885C5: 092D13B8D5296CEC79329DED60CFB04D200F101499E70C75EC8996551EA29D40262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B48B47C206C3C40C98E9C863389C9E6840FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 13/19] ARM: Fix GCC 7 -Wimplicit-fallthrough warnings. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the patch! Fixed your comments inline. On 15.08.23, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > LGTM as trivial, except for a few nits, regarding the commit message. > On Wed, Aug 09, 2023 at 06:36:02PM +0300, Sergey Kaplun via Tarantool-patches wrote: > > From: Mike Pall > > > > (cherry-picked from commit 9bd5a722bee2ee2c5b159a89937778b81be49915) > > > > This patch adds the `/* fallthrough */` comments elsewhere, where it was > Typo: s/where it was/where they were/ Fixed. > > missing for the ARM build, so the `-Wimplicit-fallthrough` [1] warning > > is trigerred. > Typo: s/is trigerred/is not triggered/ Fixed, thanks! > > > > Also, this commits sets the correspoinding flag in the > Typo: s/commits/commit/ > Typo: s/in the/in/ Fixed. > > . > > > > [1]: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-fallthrough > > > > Sergey Kaplun: > > * added the description for the commit > > > > Part of tarantool/tarantool#8825 > > --- Also added the following patch to be consisted with our codestyle in CMake. =================================================================== diff --git a/cmake/SetTargetFlags.cmake b/cmake/SetTargetFlags.cmake index d309989e..d6ee1693 100644 --- a/cmake/SetTargetFlags.cmake +++ b/cmake/SetTargetFlags.cmake @@ -9,7 +9,7 @@ include(CheckUnwindTables) # Clang does not recognize comment markers. -if (CMAKE_C_COMPILER_ID STREQUAL "GNU" +if(CMAKE_C_COMPILER_ID STREQUAL "GNU" AND CMAKE_C_COMPILER_VERSION VERSION_GREATER_EQUAL "7.1") AppendFlags(TARGET_C_FLAGS -Wimplicit-fallthrough) endif() =================================================================== > > -- Best regards, Sergey Kaplun