From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 57E0A532601; Wed, 16 Aug 2023 17:04:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 57E0A532601 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692194672; bh=2lVyPXsDCwGOujWBkTMVqKbaVnSIJCgCv4D+4e4GjcU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=gYreEnHaPWCyIXni1M/RLDsh7R2KsLTzfOar1+D83po87BKTc0Zz5kHd7vduJx2zz sz14fLPEidhyQZ9Ecd62PdijZqJA48aP4SP++tfpcEapG2XBIW2F9OYAi507tynB/0 ST7lNExo2Rxfjusqg1tnNQ85utnWU0Ht1VOexVC0= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D891D532601 for ; Wed, 16 Aug 2023 17:04:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D891D532601 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1qWH8P-0000GA-Tb; Wed, 16 Aug 2023 17:04:30 +0300 Date: Wed, 16 Aug 2023 16:59:42 +0300 To: Maxim Kokryashkin Message-ID: References: <4a61aa2abda31b52418bdfee2890be727e4738a4.1691592488.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9700E0DCE2907754D1399757346C038D9B2FE68E137CB1837182A05F538085040F2C6861488C0E7DD784FEAFD0F0B66375C33F197F8BCF6C2086CFC2E95A028D7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7370F4F695FFFC24BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378CCCB41504E044EE8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8972F692A388D6207D36AAA617E564822117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC79B25E177BEFA2CBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8B974A882099E279BDAAAE862A0553A39223F8577A6DFFEA7C741622C43FECC0DC43847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5FB14564CCB0C406C7AAED9D2EF8B00A1CDA4B0D2065D1978F87CCE6106E1FC07E67D4AC08A07B9B09E541A154B51D14BCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D348B409C2D257583DFB58A11077C6B891C379FB23918BB346E6EDCE010E5514D366CF71FB35EFAE9381D7E09C32AA3244C4372E07331603CD3F7CFE4429551EC905A1673A01BA68E40BAD658CF5C8AB4025DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojHVl7ekwB6hgNKJc3NDft0A== X-DA7885C5: BBECC522CF1A1B4E9940A3CA98E1D990B7BB13ABF80D8A67AD62F93EE3D61E35262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B0C7935BADEB243C2D29095FCBC34A4A30FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 11/19] Fix GCC 7 -Wimplicit-fallthrough warnings. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! Fixed your comments inline. On 15.08.23, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > LGTM as trivial, except for a few comments regarding the commit message below. > On Wed, Aug 09, 2023 at 06:36:00PM +0300, Sergey Kaplun via Tarantool-patches wrote: > > From: Mike Pall > > > > (cherry-picked from commit d4ee80342770d1281e2ce877f8ae8ab1d99e6528) > > > > This patch adds the `/* fallthrough */` where it may trigger the > > `-Wimplicit-fallthrough` [1] warning. Some cases still not covered by > Typo: s/cases still/cases are still/ Fixed, thanks! > > this comment and will be fixed in the future commits. > Typo: s/in the/in/ Fixed. > > > > [1]: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-fallthrough > > > > Sergey Kaplun: > > * added the description for the commit > > > > Part of tarantool/tarantool#8825 > > --- > > -- Best regards, Sergey Kaplun