From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D44ED580CAD; Wed, 16 Aug 2023 17:06:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D44ED580CAD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692194804; bh=q+K/yJemuw3gA7aR4Nq8Orcka7uMhss/VWs64glpJ8I=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=TlTeo0US+EVgVXJvuEKyQaVWvm/wqRHOiTi9/fC4d2nMJYuDdiRzscHjK+PLQWnoL FToew7KfTOVsxD81iIn1H7CzvrjlNR9RexOq8eVHxMQ2NbHX4LICGCxBkx2xBK5DGA 1BWU+LDO8l43NgVB8dIamSK3ZHgG46vjr2oHf0XU= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 13835532601 for ; Wed, 16 Aug 2023 17:06:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 13835532601 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1qWHAZ-0001C1-96; Wed, 16 Aug 2023 17:06:43 +0300 Date: Wed, 16 Aug 2023 17:01:56 +0300 To: Maxim Kokryashkin Message-ID: References: <08708e70d731d2f0ac7d30399888f5620d06df16.1691592488.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9700E0DCE2907754D9B1C46D604AD036F8866CBFA63B460F7182A05F5380850402E0BE23BF69EA2963D2EC26B994AB99705377802A613AA147BF327C9D825A649 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FCFCB92DA8654BB0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637C2EE9128AC0EB2C78638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D89ACE7C657C0C0D9D9313AC0F81382D28117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC990B2EB4F061288CA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD186FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8B974A882099E279BDAAAE862A0553A39223F8577A6DFFEA7C741622C43FECC0DC43847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A561E450DA0D9F9129FA478BF51F5A954EDB41AAEFC1D62908F87CCE6106E1FC07E67D4AC08A07B9B082B967D547A19D2FCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34BDCC71B3781C9C95C4A1A93FC9A842296B1DF9A3A594747BDA41F1AB9108CB1D1FB301FED988B6EE1D7E09C32AA3244CC981890C7BCAD13F07F13A4EFC30A414CE0B41342B755BCDBAD658CF5C8AB4025DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojHVl7ekwB6hijiGj8sPpr/Q== X-DA7885C5: C96DA50EF4D7DE971538402781FFCC19D9A0BD70F1F5CE80855504654511189C262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B8BE4F20DC628166360AB6AF4670991680FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 12/19] DynASM: Fix warning. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! Rephrased the commit message, as you've suggested. On 15.08.23, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > LGTM as trivial, except for the single comment regarding the commit message below. > On Wed, Aug 09, 2023 at 06:36:01PM +0300, Sergey Kaplun via Tarantool-patches wrote: > > From: Mike Pall > > > > (cherry-picked from commit 9b41062156779160b88fe5e1eb1ece1ee1fe6a74) > > > > This patch adds the `/* fallthrough */` comments elsewhere, where it was > > missing for the ARM64 build, so the `-Wimplicit-fallthrough` [1] warning > > is trigerred. > Since there are no 'comments', but the single 'comment', I believe a better phrasing > would be: > | This patch adds the `/* fallthrough */` comment to dynasm/dasm_arm64.h, so the > | `-Wimplicit-fallthrough` [1] warning is not trigerred anymore for the ARM64 build. Fixed, thanks! > > > > [1]: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-fallthrough > > > > Sergey Kaplun: > > * added the description for the commit > > > > Part of tarantool/tarantool#8825 > > --- > > 2.41.0 > > -- Best regards, Sergey Kaplun