From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7B030532601; Wed, 16 Aug 2023 16:57:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7B030532601 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692194246; bh=bWoei8wZjC1NYxUDJUo4/YKQrLJpzIcTlTTpZnWI03U=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=HJtZiOXF4eeAzn0Wjh6DoTcyt3Fbt5KINYJDEsBcE5d6A6/PSAH0HTk80YXXWsqP7 5p1qbt16eqI2KKwxUYueuWJSn+5hK294/GaQx9Ga+X7ZR40fCpG8B2K8SpFOtEzmcB 1uerQbZ2r39VCAYMh1p3lwwL/MBej/920NYcMICw= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9B220532601 for ; Wed, 16 Aug 2023 16:57:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9B220532601 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1qWH1Y-0005qd-OC; Wed, 16 Aug 2023 16:57:25 +0300 Date: Wed, 16 Aug 2023 16:52:37 +0300 To: Maxim Kokryashkin Message-ID: References: <3ea79a870cded9d8cd90c9b930e965d2ca075200.1691592488.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9700E0DCE2907754D1F9D5B7CD6B34A186ED0A35A424B74BD182A05F5380850405C5CAD48E22E4E6359B3D59556DFE9FF725F115CCA75B5498A20BA26E803038F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DB84ED444C624799EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372764AB4096FC590A8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D87E55471A827784A1C045501648C7DC26117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCC109CDBF71E2B98BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BAE9A1BBD95851C5BAAAE862A0553A39223F8577A6DFFEA7C741622C43FECC0DC43847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A590DF59F3F496C7273807D000630670A7F7CDB21AC13AC6B4F87CCE6106E1FC07E67D4AC08A07B9B06A1CB4668A9CA5FACB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34BC3EEE75EF3BACCFDDA54FC28A05B1FCC0A5E9F2F81C939B0FABF7FE4A1E62DB22516409E924E6E21D7E09C32AA3244C97932403B46A410704D3379D8679C96595A9E0DC41E9A4CFBAD658CF5C8AB4025DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojHVl7ekwB6hj3tBNUnr34Ng== X-DA7885C5: B533BBC92A48CCB9CB534CA80BF8E9439559434FC9DC2706BECC92AB710C8C13262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B8B857288EFEDFA7EA31E955164BCA7E60FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 09/19] FFI: Eliminate hardcoded string hashes. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! Fixed your comments inline. On 15.08.23, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, except for a few comments below. > > On Wed, Aug 09, 2023 at 06:35:58PM +0300, Sergey Kaplun via Tarantool-patches wrote: > > From: Mike Pall > > > > (cherry-picked from commit 70f4b15ee45a6137fe6b48b941faea79d72f7159) > > > > This patch refactors FFI parsing of supported C attributes and pragmas, > > `ffi.abi()` parameter check. It replaces usage of comparison (with > Typo: s/usage/the usage/ Fixed. > > hardcoded string hashes) with search in the given string with the > Typo: s/with search/with a search/ Fixes. > > format: "\XXXattribute1\XXXattribute2", where `\XXX` is the length of > > "attribute" name. > > > > Sergey Kaplun: > > * added the description for the commit > > > > Part of tarantool/tarantool#8825 > > --- > > -- Best regards, Sergey Kaplun