From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 92C89580C8B; Wed, 16 Aug 2023 16:45:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 92C89580C8B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692193502; bh=h0DyxVJSMMNe2zsyBzvt0XN6wtllWEBrrnFCXwntGpg=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=KCy2HkWcIJyieLnCg8rtb70y51lGOrhkIbZwnPG1YjimPdEQXoY0kB29ST7Vp0J4p 7WPA/hYe6sH/s3JmBmq0mHhlHAjYPSQIWB8xqCc6JSHDTBVlqTnG03/GhG8D9p1Kka ib82ueKIQrOQb+aasqV668hJtkhhomnBz4Kc8tOI= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 10B76580C81 for ; Wed, 16 Aug 2023 16:45:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 10B76580C81 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1qWGpY-0003j5-4v; Wed, 16 Aug 2023 16:45:00 +0300 Date: Wed, 16 Aug 2023 16:40:12 +0300 To: Maxim Kokryashkin Message-ID: References: <3307d2d7a9e4a959c0c5e5f51a222bd9e5201c3b.1691592488.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9700E0DCE2907754DC31F271F5537F259DF86C48FD8FFD89C182A05F538085040F7B41EF462E3AB1338E1FCED41467634BDE58EE40956BC6D1B3F35E49F7A1638 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72424932217190DC2EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E0FC02D497BF09508638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A0FCF7505EC616EA8082E86A7AAFA40D117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC11A27A05CE189FECA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8B974A882099E279BDAAAE862A0553A39223F8577A6DFFEA7C799A55B1B7C3DAF143847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A55B6823B299C983DDE9C7519FC6392A0EE4539C6DEB1EAF27F87CCE6106E1FC07E67D4AC08A07B9B013BDA61BF53F5E1DCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34D4E96E2A5B1100E0DA917328F79A990DA0AFBE084D50A2D0410BADFB3DF75B6CE4302F4320ADDAED1D7E09C32AA3244CC84701132A0C406976823A30FB05BC6D60759606DA2E136ABAD658CF5C8AB4025DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojHVl7ekwB6hgL08qCTuNArg== X-DA7885C5: C095E1CB2544A48DBE5CCF4E4E215ECBB5548C2F30CE3DB4C593F2054C492D8E262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B66120EFF37937F946CA03E1BE65638F20FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 07/19] build: fix non-Linux/macOS builds X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thansk for the review! Fixed your comments inline. On 15.08.23, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, except for a few typos below. > On Wed, Aug 09, 2023 at 06:35:56PM +0300, Sergey Kaplun via Tarantool-patches wrote: > > This patch is a follow-up for the commit > > a170eb8be9475295f4f67a086e25ed665b95c8ea ("core: separate the profiling > > timer from lj_profile"). It moves the timer machinery to the separate > Typo: s/to the/to a/ Fixed. > > module. Unfortunately, the `profile_{un}lock()` calls for Windows and > > PS3 wasn't updated to access `lj_profile_timer` structure instead of > Typo: s/wasn't/weren't/ Fixed, thanks. > > `ProfileState`. > > > > Also, it is a follow-up to the commit > > f8fa8f4bbd103ab07697487ca5cab08d57cdebf5 ("memprof: add profile common > > section"). Since this commit the system-dependent header and > > `write()`, `open()`, `close()` functions are used. They are undefining > Typo: s/undefining/undefined/ Fixed. > > on Windows, so this leads to error during the build. > Typo: s/error/errors/ Fixed. > > > > This patch fixes the aforementioned misbehaviour. After it our fork may > > be built on Windows at least. > > --- > > -- Best regards, Sergey Kaplun