From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8D2C55B18E9; Wed, 16 Aug 2023 16:18:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8D2C55B18E9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692191929; bh=XqUw8XvyUG/IkhfWqXh7NdJHLGmng55D1mHVcPsvRUU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=AtlJriBOWeymiqaiafJ72eJ+3rl3jnvVK+I4mpn/U16bhPCQ95SxDVUrNM0uVrxZU KxDBZLglfzx6cxwddD21IFR9bCG+oobSxzIMKB5wQRnlLmq/SMvVvXjTsqK5UbZfvu bcyFrCvvMGyvawB28avDwqNwNBxMfarlPf2yZRj0= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 25140532601 for ; Wed, 16 Aug 2023 16:18:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 25140532601 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1qWGQB-0007TR-5l; Wed, 16 Aug 2023 16:18:47 +0300 Date: Wed, 16 Aug 2023 16:13:59 +0300 To: Maxim Kokryashkin Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9700E0DCE2907754D4FC677755C812E332EA741D6A7864909182A05F5380850400A6F18E3676537D8943869D9498201F198A81D5F6506D43F2713C736F1D48D43 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D3E352D4AD7EBF54EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006377845AD97F799C6E88638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8ED34136090E5EFCC7AC209942DAD6E3B117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC317C7E487E00003AA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BAE9A1BBD95851C5BAAAE862A0553A39223F8577A6DFFEA7CC1948A84299AD5C643847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5F2EC27F97AF2BC0C4E4D97197632950E157C6A91B1CAFF7DF87CCE6106E1FC07E67D4AC08A07B9B0632EDEA9CD5989A3CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3475FE4AA98865E2356B319E71107AD214BFAB41CC987D143809DC87B10A5C4ECAD26C3153FD71E16C1D7E09C32AA3244C02B2AFB1D78AF1A95AEFCBDA005A7A22250262A5EE9971B0BAD658CF5C8AB4025DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojHVl7ekwB6hhEf/U8aWIUsg== X-DA7885C5: A15459A00A00ACA7BA44A81E5197E4381AA7A480C8346874981F7B5BFF5C59A7262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B1B2FB67DA47997AEDA76BC1F40469F170FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 05/19] PPC: Add soft-float support to interpreter. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! Fixed your comments inline. On 15.08.23, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, except for a few comments below. > On Wed, Aug 09, 2023 at 06:35:54PM +0300, Sergey Kaplun via Tarantool-patches wrote: > > From: Mike Pall > > > > Contributed by Djordje Kovacevic and Stefan Pejic from RT-RK.com. > > Sponsored by Cisco Systems, Inc. > > > > (cherry-picked from commit 71b7bc88341945f13f3951e2bb5fd247b639ff7a) > > > > The software floating point library is used on machines which do not > > have hardware support for floating point [1]. This patch enables > > support for such machines in the VM for powerpc. > Typo: s/powerpc/PowerPC/ Fixed, thanks. > > This includes: > > * Any loads/storages of double values use load/storage through 32-bit > Typo: s/storages/stores/ Feel free to ignore, though. Fixed, thanks. > > registers of `lo` and `hi` part of the TValue union. > > * Macro .FPU is added to skip instructions necessary only for > > hard-float operations (load/store floating point registers from/on the > > stack, when leave/enter VM, for example). > Typo: s/leave/enter/leaving/entering/ Fixed, thanks! > > * Now r25 named as `SAVE1` is used as saved temporary register (used in > > different fast functions) > > * `sfi2d` macro is introduced to convert integer, that represents a > Typo: s/convert/convert an/ Fixed. > > soft-float, to double. Receives destination and source registers, uses > Typo: s/to double/to a double/ Fixed. > > `TMP0` and `TMP1`. > > * `sfpmod` macro is introduced for soft-float point `fmod` built-in. > > * `ins_arith` now receives the third parameter -- operation to use for > > soft-float point. > > * `LJ_ARCH_HASFPU`, `LJ_ABI_SOFTFP` macros are introduced to mark that > > there is defined `_SOFT_FLOAT` or `_SOFT_DOUBLE`. `LJ_ARCH_NUMMODE` is > > set to the `LJ_NUMMODE_DUAL`, when `LJ_ABI_SOFTFP` is true. > > > > Support of soft-float point for the JIT compiler will be added in the > > next patch. > > > > [1]: https://gcc.gnu.org/onlinedocs/gccint/Soft-float-library-routines.html > > > > Sergey Kaplun: > > * added the description for the feature > > > > Part of tarantool/tarantool#8825 > > --- > > -- Best regards, Sergey Kaplun