From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 045705B18E2; Wed, 16 Aug 2023 16:15:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 045705B18E2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692191723; bh=6fYuN3MzviTNNZk55x7l2KsQvBs7AX9l1MLfGwS1vEQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=oqnN4xJ0MEwsfbb7uCZb91H/ROJ11DakC0XRMG0VBWmPont1X13DWVoEGzBlzuSFI Df6v//cVowZdCPqE76nOq5eClw+j7ddLipiXx2I8wnSeikbdJMNByVjh/6EEhWC6xT smhxq4s5EO90T5tQzdfTeLH4Gw5h2jHAKStTq6gM= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A96295B18E1 for ; Wed, 16 Aug 2023 16:15:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A96295B18E1 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1qWGMq-0006Dm-O8; Wed, 16 Aug 2023 16:15:21 +0300 Date: Wed, 16 Aug 2023 16:10:33 +0300 To: Maxim Kokryashkin Message-ID: References: <3g4ignpxfsymtf5i2p3z4nyguilhfe7rcp5icloqqqawhyymv6@iix2auzbs6ed> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3g4ignpxfsymtf5i2p3z4nyguilhfe7rcp5icloqqqawhyymv6@iix2auzbs6ed> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD93AA62145E837FE287BD17FB31885916E472656A32A0A88AB182A05F5380850404C228DA9ACA6FE27517D18E4DEE5B9FFB08F0DF6B20E377EAA13B94A82FAEE38F5B2DB967B27180F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7CF4D16325FBE1EEDEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375E7A1B5661595F038638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D820A0C6FAE3039C70C59133F23B691C59117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCE1488AC3D4DED311A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BF80095D1E57F4578AAAE862A0553A39223F8577A6DFFEA7C5B09DCDDD98ABCD243847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A51DEF323D5620966608EC5A2F97CD4787621F01B9B7AD4A6EF87CCE6106E1FC07E67D4AC08A07B9B0AD0E433DBF1FBFA3CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34951738D4D62E58A4AA0D458888D9ADD3DB3C88620DDD8DAB651ED951A012E03E05072724E9886B721D7E09C32AA3244C73A162A34A5F64711E0E33EBBAB874443C6EB905E3A8056BBAD658CF5C8AB4025DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojHVl7ekwB6hg9aHDDujdYTA== X-DA7885C5: F699A940438D7689FD8F246BC92780F375035A64D037D64DC005C7B5D444AD0E262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B9186DFF8025D8047F53D83E1CEFB9CDA0FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 04/19] MIPS64: Add soft-float support to JIT compiler backend. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! Fixed your comments inline. On 15.08.23, Maxim Kokryashkin wrote: > Hi, Sergey! > LGTM, except for a few comments below. > On Wed, Aug 09, 2023 at 06:35:53PM +0300, Sergey Kaplun via Tarantool-patches wrote: > > From: Mike Pall > > > > Contributed by Djordje Kovacevic and Stefan Pejic from RT-RK.com. > > Sponsored by Cisco Systems, Inc. > > > > (cherry-picked from commit a057a07ab702e225e21848d4f918886c5b0ac06b) > > > > The software floating point library is used on machines which do not > > have hardware support for floating point [1]. This patch enables > > support for such machines in JIT compiler backend for MIPS64. > Typo: s/in JIT/in the JIT/ Fixed. > > This includes: > > * `vm_tointg()` helper is added in to convert FP > > number to integer with a check for the soft-float support (called from > > JIT). > > * `sfmin/max()` helpers are added in for min/max > > operations with a check for the soft-float support (called from JIT). > Typo: s/the soft-float/soft-float/ Fixed. > > * `LJ_SOFTFP32` macro is introduced to be used for 32-bit MIPS instead > > `LJ_SOFTFP`. > > * All fp-depending paths are instrumented with `LJ_SOFTFP` or > Typo: s/fp-depending/fp-dependent/ Fixed. > > `LJ_SOFTFP32` macro. > Typo: s/macro/macros/ Fixed. > > * The corresponding function calls in are marked as > > `XA_FP32`, `XA2_FP32`, i.e. as required extra arguments on the stack > > for soft-FP on 32-bit MIPS. > > Shouldn't we also mention the `asm_tobit` function? I suppose no, since it still just another implementation for SOFTFP && LJ_64 mode. > > > > [1]: https://gcc.gnu.org/onlinedocs/gccint/Soft-float-library-routines.html > > > > Sergey Kaplun: > > * added the description for the feature > > > > Part of tarantool/tarantool#8825 > > --- > > -- Best regards, Sergey Kaplun