From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <tarantool-patches-bounces@dev.tarantool.org> Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 650EB58AE3D; Tue, 15 Aug 2023 22:06:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 650EB58AE3D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692126381; bh=ltH8MD2vKQB1PzyO3tqY9pGuWAADtHoedlGHwA+3C+k=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=htsInyhyaULltL1eWPV/GOJB3616q1y7Ur23eYEckSbrTDrUPRWSDBhVvl0amgFbw JKK9q2nZSuB25pkVTgfnQKsaafOgcDLXn+XPsRJjdpHOq0FoEef6JXIObLiKaO/o8l KqKO+1Gt0WXdL24lMH28gwgI7dXAzzcWX6JFBQxw= Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [95.163.41.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5F00458AE38 for <tarantool-patches@dev.tarantool.org>; Tue, 15 Aug 2023 22:06:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5F00458AE38 Received: by smtp35.i.mail.ru with esmtpa (envelope-from <imun@tarantool.org>) id 1qVzMq-009U1F-1s; Tue, 15 Aug 2023 22:06:12 +0300 Date: Tue, 15 Aug 2023 18:51:09 +0000 To: Maxim Kokryashkin <max.kokryashkin@gmail.com> Message-ID: <ZNvJHe4vRd4wZ85p@tarantool.org> References: <cover.1690834846.git.m.kokryashkin@tarantool.org> <2b57c59938395c0e2ce491e7bdf3b8d08a246b8f.1690834846.git.m.kokryashkin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2b57c59938395c0e2ce491e7bdf3b8d08a246b8f.1690834846.git.m.kokryashkin@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD969E04B5EED670DC8BEB87106826C459512B2000DD660D84D182A05F53808504082A7F559B990F1AE728FDFF5C69952CF9323CA033413D029DD374BF17586024D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C2204D4F9A221771EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637C8BD49B17AF1FC7C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D834520AEFC65500183456E6BE63021FD5117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCCA3E976C47030043A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520140C956E756FBB7AC26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEB28585415E75ADA9C5236E9430F51F07D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3AD74539164518AE52D242C3BD2E3F4C6C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637870CFFD37CCFDD3AEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A57BEDE599027911A3F73D8C1215E7F9CFF03BE6AF0DAC99A5F87CCE6106E1FC07E67D4AC08A07B9B07BD21ED50D08CA4DCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34BF5454112BD5BFD7454853B0AE7FA835DC61A6D19D6A0E5943FB7CD59E17F3976D14FCBA0D1F78D71D7E09C32AA3244C6C8A673609EBFA5EFDFAE76BD277289CB018FE5BB746DCD1ED9A463B7D0AAFF65DA084F8E80FEBD376A4ED3E9341DC2FCD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojHVl7ekwB6hhmYjbM9iyIjw== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D531C5457C28D7343342E57488FC006E6CC6605418E3C403A8BC2326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v3 2/4] sysprof: remove `split by vmstate` option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org> List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe> List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/> List-Post: <mailto:tarantool-patches@dev.tarantool.org> List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help> List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe> From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> Reply-To: Igor Munkin <imun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" <tarantool-patches-bounces@dev.tarantool.org> Max, Thanks for the patch! Same for this patch: I would like to ask you to add some more rationale for removing this (i.e. why it was implemented and why it is considered unused). On 31.07.23, Maxim Kokryashkin wrote: > This option is unneeded and was never used > by anybody. There is no reason to maintain it > in the scope of refactoring. > > Needed for tarantool/tarantool#8700 > --- > tools/sysprof.lua | 9 +-------- > tools/sysprof/collapse.lua | 10 +++------- > 2 files changed, 4 insertions(+), 15 deletions(-) > <snipped> > -- > 2.41.0 > -- Best regards, IM