From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 02AED58AE38; Tue, 15 Aug 2023 22:05:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 02AED58AE38 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692126351; bh=rwq9iG003XAVOVnFTJSrxY2kUu2SPxS37Rr/y7A1Wf0=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ZFa+mn2a8CTkQGNTxxuiVNMFMH4oVQaIX5G4YyDe7/yMk3opjnWhr4Nshh47C1+Je DgsHWS8yrnqOgXUXFNAfuAc1KDitzg2rj6bLNiOdoVi/pqNJMjJKyECS/2E/LSrf5A z1/dy675htB4VJUyIde0TmaRm6FNDdUNl+Zrf3pI= Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [95.163.41.90]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7567D553E0B for ; Tue, 15 Aug 2023 22:05:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7567D553E0B Received: by smtp53.i.mail.ru with esmtpa (envelope-from ) id 1qVzMS-000lB2-2N; Tue, 15 Aug 2023 22:05:49 +0300 Date: Tue, 15 Aug 2023 18:50:45 +0000 To: Maxim Kokryashkin Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD969E04B5EED670DC8E1D56388F8ECDB9EA9DEC181E9DCB203182A05F538085040A6836634FADA273ECCF4A6E1C822193830F8D0C419A5D11E02BA088EF147B98A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE71BDE6A359BD5B800EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378A9F193E39E334918638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8B9BD4BE85BBC73BA65BF4919BBB36AE4117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF80095D1ED7F4578A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10FF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CAD74539164518AE52D242C3BD2E3F4C64AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3E6DA32D78056113CBA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7888FFA144A8AE6D0731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A54437C982CFA3C9DAFD54BA2F8778DCD8AB328C8B445D24CFF87CCE6106E1FC07E67D4AC08A07B9B0724336BCC0EE1BA8CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D345C110A855FC099991095464F72202D54BC3D1564C31843549371E40113962DCE354C4D1994E510A61D7E09C32AA3244CB08F01BCDCB9CB16CB2D7559508CEE7E69B6CAE0477E908DED9A463B7D0AAFF65DA084F8E80FEBD376A4ED3E9341DC2FCD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojHVl7ekwB6hjh2yTKIkUnKQ== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D531C5457C28D7343342AA808E7B6445E6CA4A99D73951F462E92326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v3 1/4] utils: remove unnecessary insertion in AVL-tree X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the patch! The change is quite clear, but so-called 'gen' was introduced on purpose AFAIR. Hence, I would like to ask you to describe this change or clarify my gen misunderstanding. On 31.07.23, Maxim Kokryashkin wrote: > This patch fixes a bug in the AVL-tree implementation, > which produced unnecessary inserts of values into nodes, > instead of replacement. > > Needed for tarantool/tarantool#8700 > --- > .../tarantool-tests/gh-5813-resolving-of-c-symbols.test.lua | 6 ++---- > tools/utils/avl.lua | 4 ++-- > tools/utils/symtab.lua | 2 +- > 3 files changed, 5 insertions(+), 7 deletions(-) > > -- > 2.41.0 > -- Best regards, IM