From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A4EC7553E0B; Tue, 15 Aug 2023 22:09:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A4EC7553E0B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692126584; bh=Qwr9S2Olz13M8PlsNxJp0SWkMrkW68TwYpWc0i9yC9M=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=O1iuBKTnB2M5FHP8SId8nKxZl74/w72WUr2ARIz2Ns0eQXwef5bCGRHgeluxWLs7U ZrOEekomwRcVU1kepGi8ppdiDDGDbCwPGSiF7FtEJQmTq0ce967ZciE+8C7L62JSUu ZB3iPUWW12oyhitHP1r+U4EQVebc1NgpNhMsWIWc= Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [95.163.41.92]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0D35F553E0B for ; Tue, 15 Aug 2023 22:09:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0D35F553E0B Received: by smtp50.i.mail.ru with esmtpa (envelope-from ) id 1qVzQC-007NFr-2i; Tue, 15 Aug 2023 22:09:41 +0300 Date: Tue, 15 Aug 2023 18:54:38 +0000 To: Maxim Kokryashkin Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD969E04B5EED670DC8BEB87106826C459512B2000DD660D84D182A05F5380850408CD0C7653834DD6714CD4E46A1E513D92266AF9D96DABCF19AE65BBE8A25B3DF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73B44982FA5E78411EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D07BBD2EBFB7BF888638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D80FE2BF6C6FFE9695CEFC92BE399DB0F5117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC990B2EB4F061288CA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18E5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE140C956E756FBB7AB1CA5D0BF4193578D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE32A336C65186350916E0066C2D8992A16C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F790063757B1FBEA53BC6EDBEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5EADD3597428A5F87C4BF5D61837E514C7DE98A16635393DAF87CCE6106E1FC07E67D4AC08A07B9B0CE135D2742255B35CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34ADE558D2B396DA7C42458CA150FB84EDA9626A122B5607A85816CDCED6A9D0F3D1EB166B8C88571E1D7E09C32AA3244C5E20D3BB0BDD3F56F2685A20E2CABBD539C99C45E8D137E9ED9A463B7D0AAFF65DA084F8E80FEBD376A4ED3E9341DC2FCD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojHVl7ekwB6hj5vZ7M15+Shg== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D5319F07F01490C60AF0A9E539D8E082B66B8B323A312B9E97B12326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v3 0/4] sysprof: parser refactoring X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the fixes! Please consider my comments per patches. On 31.07.23, Maxim Kokryashkin wrote: > This patchset is targeted at reducing the memory footprint > of the sysprof parser. It is mainly achieved by fixing a > nasty bug in the AVL tree implementation, which caused most > of the memory consumption, and by essentially purging the collapse.lua > module, which means that there is no need to store the complete > information about every parsed event and it is sufficient to merge > stacks inplace. > > Alongside with described changes two minor improvements were done: > - `luajit-parse-sysprof` now has permissions to be executed > - `split_by_vmstate` option is purged, because no one uses it, so there > is no actual reason to maintain it. > > ## Note for Igor: > There is no way to split the 'memory footprint reduction'-part and the > 'collapse.lua purge'-part, since the main reason why memory consumption > is so much lower now, other the AVL-tree bug, is that we don't need to > pass a complete profile information between the `parse.lua` and > `collapse.lua`. That, basically, almost turns the profile parsing > process into some kind of stream-based procedure. Got it, thanks for explanation! > > PR: https://github.com/tarantool/tarantool/pull/8703 > Branch: https://github.com/tarantool/luajit/tree/fckxorg/gh-8700-sysprof-parser-refactoring > > Maxim Kokryashkin (4): > utils: remove unnecessary insertion in AVL-tree > sysprof: remove `split by vmstate` option > tools: add execution permission to sysprof parser > sysprof: improve parser's memory footprint > > .../gh-5813-resolving-of-c-symbols.test.lua | 6 +- > tools/CMakeLists.txt | 4 + > tools/luajit-parse-sysprof.in | 0 > tools/sysprof.lua | 28 +--- > tools/sysprof/collapse.lua | 127 +----------------- > tools/sysprof/parse.lua | 126 ++++++++++++----- > tools/utils/avl.lua | 4 +- > tools/utils/symtab.lua | 2 +- > 8 files changed, 106 insertions(+), 191 deletions(-) > mode change 100644 => 100755 tools/luajit-parse-sysprof.in > > -- > 2.41.0 > -- Best regards, IM