From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9CBC7576B40; Wed, 9 Aug 2023 18:50:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9CBC7576B40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1691596259; bh=wydO7y1U70TAv369zY/cOdTwPaDwH7KXF9CFT8kwLqc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=a1ycjhs+oZ1QBUZiP22kwsnukTqPJbOVZCaOr+ljEBV1UHvy30pRNN7htQDmfCiNP XJVR+w43qmcIGNrK2L5Ef3/uQNm/5Uy1ADDuys+5UHj/GZkOlbw7GYCdvcB4YIyl6u HLbZP2hYAmJ/GPVBdeIxZ9pW0CWDhZzBg84x95Kk= Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [95.163.41.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 30C425764BC for ; Wed, 9 Aug 2023 18:49:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 30C425764BC Received: by smtp39.i.mail.ru with esmtpa (envelope-from ) id 1qTlRY-00DPxk-1D; Wed, 09 Aug 2023 18:49:52 +0300 Date: Wed, 9 Aug 2023 18:45:05 +0300 To: Sergey Bronnikov Message-ID: References: <1691091489.404344804@f148.i.mail.ru> <0b5bc26f-cf20-2b13-ce53-c1a5ebeabe5d@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD969E04B5EED670DC8841989C3708580A974F6E13231883BD2182A05F5380850408270E7EB3EB6CECBA4ECC2B8E12072B52486F38987A6E34CB12A376CDAEEDC05 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE763424119D34F5CBFEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379B0255B5E5688AF88638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D860B763C730DEF85382E6F3CF37BC9EF7117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCE566BBE820FEB67CA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD186FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE0AC5B80A05675ACD9935A1E27F592749D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3F8BD4E506CFA3D88C0837EA9F3D19764C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637BBEA499411984DA1EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A549BA994F0551AE35C862149A3829A1963FE6D546EE1A1C12F87CCE6106E1FC07E67D4AC08A07B9B04AB4081B6A6C2E07CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D344EF254DC71474AA3F359A399CD396BDB4F8C0E8015DDA6F5685F4347B152103E630703700E423FF31D7E09C32AA3244C7EBA06DF2F8F311D3F04453AFE6DC6CA725D5B54B2FE4575ED9A463B7D0AAFF65DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojUzxoxvtYX2pne9yw5Pjr5g== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A76936E225ABA0E56C39A4ECC2B8E12072B5DDEE725E12766E67DEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 3/5][v3] cmake: introduce new targets X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: Sergey Bronnikov , max.kokryashkin@gmail.com, tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the fixes! On 09.08.23, Sergey Bronnikov wrote: > Hi, Sergey! > > On 8/9/23 17:04, Sergey Kaplun wrote: > >>  include(LuaJITUtils) > >>  include(SetBuildParallelLevel) > >>  include(SetVersion) > >> +include(CheckPatch) > > And be included from test/CMakeLists.txt, not from root CMakeLists.txt. > Why? How checkpatch is related to testing? Not so much, but we still have `LuaJIT-luacheck` target in testing. I expected the same from `LuaJIT-checkpatch` target (and `test` target depends on `LuaJIT-checkpatch` target). But we may also move `LuaJIT-luacheck` in the separate include file in the separate patch series. > > > >> +    WORKING_DIRECTORY ${PROJECT_SOURCE_DIR} > > Also, we can't just check all patches with this since it will have > > TONS of errors. We must at least exclude all , and > > include back files that are maintained by us. > > > > Without this, it becomes pointless, since we either > > * will have red always checkpatch job and don't be aware, so can miss > > some errors, either > > * will set ignore all (or something like it) to ignore all checkpatch > > warnings, including meaningful one. > > Agree, but this requires patching checkpatch itself, right now it is not > possible > > to suppress warnings for a certain files in patch. I'll try to implement > such patch. Looking forward to it! > -- Best regards, Sergey Kaplun