From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7F6F25799EB; Tue, 8 Aug 2023 13:52:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7F6F25799EB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1691491946; bh=1p1eYk7THw6epQT89401ZO/03lCReyHUf4EHeoZWdwg=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=hkg4Yh2zzG5xkAcUmpNP/fptfyXw9NBtLlT+tQI35vpO2gRWhLBF6Mb1aFafqq6fP Ny2SGzWWNVGAHVWT6mMOeCIbQ1kdUU7jI90b+iRAJJaXZNl42/W2iuiUiCi94kwr8X AWWn90U13aZnitXw/Rlj9hGkXwaDvUxi2zNB+OtU= Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [95.163.41.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9A68456B38D for ; Tue, 8 Aug 2023 13:52:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9A68456B38D Received: by smtp48.i.mail.ru with esmtpa (envelope-from ) id 1qTKK7-00D5A7-0q; Tue, 08 Aug 2023 13:52:23 +0300 Date: Tue, 8 Aug 2023 13:47:36 +0300 To: Sergey Bronnikov Cc: Sergey Bronnikov , tarantool-patches@dev.tarantool.org, max.kokryashkin@gmail.com Message-ID: References: <4a26e6a1f06191178c385a1df62d61763a5743e3.1690293120.git.sergeyb@tarantool.org> <696ac7ac-b93d-84ff-3285-f1a848c6bdde@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <696ac7ac-b93d-84ff-3285-f1a848c6bdde@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD969E04B5EED670DC804E38A5F9341E5D89B81E0241E25E490182A05F53808504075FA870DC18E02659C774D143E059860C25EAE0985216EC6D6DA1EF59808D94E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75037DDE13FB75316EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637826327602763C04B8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8F274ECF55B0392E1343044B856C548B6117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC55D5BE2F85BDEC5FA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520437C869540D2AB0FC26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE0AC5B80A05675ACD03F1AB874ED890284AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C369BF13FED57427F176E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB33AC447995A7AD18262FEC7FBD7D1F5BD5E8D9A59859A8B67122B551D37F75FD089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5D28893ABDE16E288EA7DA1FD2C215E85058869D06ED57F52F87CCE6106E1FC07E67D4AC08A07B9B02A336C6518635091CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFCBCD2E5E0B7AA35A1D880488FE1BA2597475A7AA3AE62178649C819ACC58110D2A6269F78606922F1529AA6C8ABD04CA193BCDEBCB174FDAD52E3E2FD719A4B9A74DFFEFA5DC0E7F02C26D483E81D6BE5EF9655DD6DEA7D65774BB76CC95456EEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj/xSHLV4ZQPtzSyzI2ipUfg== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769AEB2358C7112C9889C774D143E0598607B0B9A7C4E99E59BDEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] cmake: add code coverage support X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the fixes! LGTM, except the last minor nit ;). On 08.08.23, Sergey Bronnikov wrote: > Hello, > > > diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml > index 78abf2e1..13ea6c5b 100644 > --- a/.github/workflows/coverage.yml > +++ b/.github/workflows/coverage.yml > @@ -50,8 +50,10 @@ jobs: >        - name: build >          run: cmake --build . --parallel >          working-directory: ${{ env.BUILDDIR }} > -      - name: test and generate code coverage report > -        run: cmake --build ${{ env.BUILDDIR }} --parallel --target coverage > +      - name: run regression tests > +        run: cmake --build ${{ env.BUILDDIR }} --parallel --target test I suppose it should be LuaJIT-test, since we don't want to run linters here. See also [1]. > +      - name: generate code coverage report > +        run: cmake --build ${{ env.BUILDDIR }} --parallel --target LuaJIT-coverage >        - name: send code coverage to coveralls.io >          run: | >            curl -LO https://coveralls.io/coveralls-linux.tar.gz > > [1]: https://github.com/tarantool/luajit/actions/runs/5794532687/job/15704307515#step:7:46 -- Best regards, Sergey Kaplun