From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C48EE57A79F; Fri, 18 Aug 2023 11:01:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C48EE57A79F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692345700; bh=UsJD2sTkorS1xCX0BalB5l9F9gDm1UjYzGlqyS9+V7I=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=hgVDV1qKPTpzX6I8nb9YWfx5wuTRP9lJCc611OUoiW4YmblwCoAbrT6f/311lpFh+ JYd9DWo4uxGf62A8c7oW8bS9guz7eSMDXi7uuabjNtAYQIfLI5RGU9esMf2ZDDBa0G BFNwJ0kT8qg2mMKM4W3QOSZisb+PrNBuPjnDwTHQ= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0FC4855C707 for ; Fri, 18 Aug 2023 11:01:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0FC4855C707 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1qWuQM-0007lE-7m; Fri, 18 Aug 2023 11:01:38 +0300 Date: Fri, 18 Aug 2023 10:56:51 +0300 To: Maxim Kokryashkin Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9700E0DCE2907754D4D249011687940C6678A0DD020DA6E3B182A05F53808504067E78799A121A08DEC16DC5C1D12F3980735FE72F27510A449690D303E43B90F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73B44982FA5E78411EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375B4C42A189C515578638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D84D2772285C6264D0E989172B20FB2C53117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC4871F77D444DC01FA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8B2EE5AD8F952D28FBAAAE862A0553A39223F8577A6DFFEA7C8BDE37D78FCB031643847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A51E36AB80AE880B73268369242A8E9E8E459503B0F9F2E5E1F87CCE6106E1FC07E67D4AC08A07B9B082B967D547A19D2FCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34E3E1DC0F9BD5530911778F26892259BCAB06B6EA69054C24097E3D9659FE9F276760A9BAE83CB0481D7E09C32AA3244CE38B64429117C5C751F05DA9BCBC1CBD3E8609A02908F27185A42E4C463514DC5DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojgZIFrgxvv3ry7OWzQXSekg== X-DA7885C5: 3E1E3E9B41BD9A4A69B1991A66CB952903209ABCA28C7B38D5C89A5F41050617262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B1AE86FE04A393F3F1F798ACA2570FDD60FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/5] Improve assertions. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! I fixed your comments and force-pushed the branch. On 17.08.23, Maxim Kokryashkin wrote: > Hi! > Thanks for the patch! > LGTM, except for a few comments below. > > Side note: glad to see, that you didn't forget to enable the > assertions we decided to replace with convetional ones, awesome work! Nice to hear:). > On Tue, Aug 15, 2023 at 12:36:29PM +0300, Sergey Kaplun wrote: > > From: Mike Pall > > > > (cherry-picked from commit 8ae5170cdc9c307bd81019b3e014391c9fd00581) > > > > This commit refactors assertions used in the LuaJIT. It introduces new > Typo: s/introduces/introduces the/ Fixed, thanks! > > module with the `lj_assert_fail()` implementation. > > Wrappers of this function are used across the whole code base. Each > > macro wrapper is defined in the corresponding module gets global state > Typo: s/module/module and/ Fixed. > > (if possible) from its environment to be passed inside the assertion. > > For now, the global state is unused, but later it may be used for > > dumping of the VM state. > Typo: s/of the/the/ Fixed. > > > > Sergey Kaplun: > > * added the description for the feature > > > > Part of tarantool/tarantool#8825 > > --- > > -- > > 2.41.0 > > -- Best regards, Sergey Kaplun