From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B8C0D5C287D; Thu, 17 Aug 2023 17:04:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B8C0D5C287D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692281071; bh=F55Rzb0fttBbekqZt6REOLTI3zvTiVPE71XNSCghSIo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=dK8nyeYPTxpYwPCOk5ROyenD74m2AOpXK4v8IkAwebcxX9xZQ5ibiZFXvJwuOMncN M12wFIfOqMgkkrK527BBtKfRMfVoyttCb7AIQ1nnrCHMYMVETMaZQQ5Y1++UktV82l ZBa1/DI7O05Aj40/Uah5dMGYSd+vKTlYNTLceu/0= Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [95.163.41.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EB2005C287D for ; Thu, 17 Aug 2023 17:04:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EB2005C287D Received: by smtp48.i.mail.ru with esmtpa (envelope-from ) id 1qWdbx-00FUHL-0b; Thu, 17 Aug 2023 17:04:29 +0300 Date: Thu, 17 Aug 2023 16:59:42 +0300 To: Sergey Bronnikov Message-ID: References: <876736e650dcb70ce32a272f92cc3ba034a4dd3b.1691592488.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9700E0DCE2907754D77D6FA938422CA5F653AC3988EEC6B12182A05F538085040F7E9DA097356C3D307983284D5629E1C970804BAE630761E814825BECF6C8155 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BC08626EA5717D14EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D3A9DC970DD6E2F6EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BE5CCB53A13BC8DBA548E5607583E1DB581CADF9FB9939CD6CC7F00164DA146DAFE8445B8C89999728AA50765F790063706CBA4EB72A0A67C389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8FA486DC37A503D0BF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CF8BD4E506CFA3D88C0837EA9F3D197644AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3D8561A2FEC730ACEBA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF17B107DEF921CE791DD303D21008E298D5E8D9A59859A8B6D52CD31C43BF465F75ECD9A6C639B01B78DA827A17800CE75B51C8FB0C3E748C731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A598923C5B130020EA5AB1BE9072B2EADF22F9E6702B584B29F87CCE6106E1FC07E67D4AC08A07B9B00A6B3CD6EB70C818BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34FD9114F69CA58D1E66D6C05BAE9832B47F9EAD79C7946997DAF1644127CB15D393E2F19861059D0F1D7E09C32AA3244C4D961B13E282674413EA4B5D99AEB5385A1673A01BA68E4085A42E4C463514DC5DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojFRrmMqSMPxo6EogSYq+B1w== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A7695DD2270B1EA4D24107983284D5629E1C7CF96F699FB25259DEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 19/19] MIPS: Add MIPS64 R6 port. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! On 17.08.23, Sergey Bronnikov wrote: > Hi, Sergey! > > > thanks for the patch! > > LGTM, after fixing extra whitespace in commit message. > > > Sergey > > On 8/9/23 18:36, Sergey Kaplun wrote: > > From: Mike Pall > > > > Contributed by Hua Zhang, YunQiang Su from Wave Computing, > > and Radovan Birdic from RT-RK. > > Sponsored by Wave Computing. > > > > (cherry-picked from commit 94d0b53004a5fa368defa4307a17edcdb87fe727) > > > > This patch adds support for MIPS Release 6 [1] for the 64-bit build. > > This includes: > > * Global `_map_def` value is set with . `MIPSR6` key > > specifies the corresponding instruction set support. Also, `MIPSR6` is > > defined in `DYNASM_FLAGS` (`DASM_AFLAGS`). > > * New instructions are added within , they are > > used if the aforementioned key is set. > > * Obsolete instructions (that are no more in use in r6) are used in the > > opposite case (if `MIPSR6` isn't set). > > * New opcode maps are added into . > Nit: double whitespace before "<". > Fixed, thanks! Branch is force-pushed. > > > -- Best regards, Sergey Kaplun