From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BF81F5C2875; Thu, 17 Aug 2023 17:02:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BF81F5C2875 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692280940; bh=BwcFpjtdjQRGT5rvhdf4o8SriUztk/h4aRx7ue7aQcc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=J5lF2PAOaT890txnNXUHi8XTQlX/dF+j0Y+kATQP2JQHbWRRRPxswYZErGFVh1ZyP loA5fitrGUYNOKm4LIZ4m/e+ymDQuNihFDrywbQ4X+T6Y8EpuhjErC+sYaO1m8O8xY /Xp77Avox+nmo6qeQtxPbRjmkdN9Owhl1iLZNd5A= Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [95.163.41.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 38E145C2843 for ; Thu, 17 Aug 2023 17:02:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 38E145C2843 Received: by smtp57.i.mail.ru with esmtpa (envelope-from ) id 1qWdZq-00BtrL-1x; Thu, 17 Aug 2023 17:02:18 +0300 Date: Thu, 17 Aug 2023 16:57:31 +0300 To: Sergey Bronnikov Message-ID: References: <713d9ff4-87ff-03a0-1f89-72b8b9b4b9d5@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <713d9ff4-87ff-03a0-1f89-72b8b9b4b9d5@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9700E0DCE2907754D1399757346C038D9B2FE68E137CB1837182A05F5380850404030FB0748D8CF66CAA6AEFEEEB03BBF201634CD4FFF08ED6023077165C6992C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE728F774C865CF4B07EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B9ECF1867A781AFF8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D88A0B145B076F27FE3920FFB7C6CA8161117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3EA24FE487C076E5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751F2CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE140C956E756FBB7A452896749CDDA0A6D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE32A336C651863509103F1AB874ED89028C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947C2FFDA4F57982C5F42E808ACE2090B5E1725E5C173C3A84C34964A708C60C975A089D37D7C0E48F6C8AA50765F79006377F02F59195295693EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A584CA9E7AE6508E37C8374245B384F69744291DE55C21DD7DF87CCE6106E1FC07E67D4AC08A07B9B013BDA61BF53F5E1DCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D346C409ABC5F9C579B8A15BCDC8CA3DA457C55922A35802C534F8FAB9A5F0F254696AE1327DF13D80D1D7E09C32AA3244C4A7DE8E93D0B69078837C1EB63A3C18BF26BFA4C8A6946B8BAD658CF5C8AB4025DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojFRrmMqSMPxrKjyEBkJlVzw== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769FCB3C181E2B8A182CAA6AEFEEEB03BBFBA0848438379BFCEDEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 16/19] Prevent integer overflow while parsing long strings. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! On 17.08.23, Sergey Bronnikov wrote: > Hi, Sergey! > > > thanks for the patch! > > test duration is about 7 sec, I propose to add a print before string.rep: > > print('# test generation requires about 7 sec') I suppose it is a good thing to do, but there is another one test (gh-7745-oom-on-trace.test.lua) which takes a long time too. Maybe it's better to create a group of "long tests", or something like that. Also, we may introduce `test:comment()` helper which provides the same behaviour as the `test:diag('# ' .. fmt, ...)` and use it in all long tests. But I prefer to do it in the separate patch set, since this one is already huge enough :). > > Otherwise it looks like test hang. Feel free to ignore. > > > LGTM after fixing comments from Max. > > > Sergey -- Best regards, Sergey Kaplun