From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C852C5C320B; Thu, 17 Aug 2023 18:07:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C852C5C320B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692284879; bh=BRmHAe1cIObbiWcwDbU9/dB6zIYS4geuezYSoFr4k2s=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=nPXAr/rAuEFXgt4kUYfalXoPa5lStuP75k/Wd/b3FTEsjcdwR5V+aaNNh/FS8ibJM lqn/OEw4iXpXyV61/SjmWFajW0GsP6zdnUnmlHl468kLap4NfvcIEFz8KXv7tzSaNf SApKNQGIJ5QWOTXwnvQ3zsihq43XfsWA61r7s45M= Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [95.163.41.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BCEFA5C320B for ; Thu, 17 Aug 2023 18:07:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BCEFA5C320B Received: by smtp59.i.mail.ru with esmtpa (envelope-from ) id 1qWebN-00E13h-2M; Thu, 17 Aug 2023 18:07:58 +0300 Date: Thu, 17 Aug 2023 18:03:10 +0300 To: Maxim Kokryashkin Message-ID: References: <28c7aec4df761b06208cc7ccd9055dd444ed2a70.1692089299.git.skaplun@tarantool.org> <4hdr4pngl3cxnwraf5jlxw2ozemaafc44blh45eu26z3dh4t34@cpjfru3carsq> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4hdr4pngl3cxnwraf5jlxw2ozemaafc44blh45eu26z3dh4t34@cpjfru3carsq> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9700E0DCE2907754D12A1D0741C7E82ED7F70A80435AA08BE182A05F538085040D3EE56B1FF75F09A405145D4563722893CFB7464EA9E0A3B29873F82DB0BFB32 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7544B1CCE26E01C74EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CDA1F22AAA442F218638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8DEFEC1A6992B84C97A45F468736D1BA6117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC206EB891B201A04DA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE0AC5B80A05675ACD9100238FE36DC7A2D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3F8BD4E506CFA3D886136E347CC761E07C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407978DA827A17800CE7A03885E80CDF58692DBA43225CD8A89F616AD31D0D18CD5C57739F23D657EF2BB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5160465BA8EAE9B4D3D37ED4B81417C3BB1F81E620164DE40F87CCE6106E1FC07E67D4AC08A07B9B0FE4D9CDE3FF759CFCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D349A401E2B4D763A4A9E2AD9B818C7B80EB0B028467CE1CEFCE8EC92089F16768C319C34A58AF244A41D7E09C32AA3244CD9C0E8AAB510CC0A808D3F8C8E764FA3853296C06374E60285A42E4C463514DC5DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojFRrmMqSMPxqU51LlyVIA3w== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769CF93193F202050C8405145D456372289009DB4CE3002C7DBDEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/5] test: introduce `samevalues()` TAP checker X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! Updated the commit message as you suggested. On 17.08.23, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, except for a few comments below. > > On Tue, Aug 15, 2023 at 12:36:27PM +0300, Sergey Kaplun wrote: > > The introduced `samevalues()` helper checks that values in range from > Typo: s/in range/in the range/ Fixed. > > 1, to `table.maxn()` of the given table are exactly the same. It may be > > usefull for test consistency of JIT and VM behaviour. Originally, the > Typo: s/usefull for test/useful to test the/ Fixed. > > `arr_is_consistent()` function was introduced in the > > . `samevalues()` has the same > > functionallity (except usage of `table.maxn()` instead `#` operator to > Typo: s/functionallity/functionality/ > Typo: s/except/except for the/ > Typo: s/instead/instead of the/ Fixed all, thanks! > > be sure, that the table we check isn't a sparse array). > > --- > > -- Best regards, Sergey Kaplun