From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 79BD1581FDB; Thu, 17 Aug 2023 12:02:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 79BD1581FDB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692262956; bh=XNI7ooM4028s4Yih7FC03RIOTozwLSgyJ2JDuoaspLo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=WY5SnmREiREDNuv2Tf0GxxvgBFaN0wBC4pG4JBPrtmsKjrbes5brwQWotWG/hImiS zcxdWZvaTs/RjIQqfQgHf1axTBouJbkZMlFxgd1GQps0HhnMTBz6keiNe8ZVwvCaIy hdgcoGoPMYazY1Pi6lIrow92V6qiZpmTxEEKXPas= Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [95.163.41.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DD36C581FDB for ; Thu, 17 Aug 2023 12:02:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DD36C581FDB Received: by smtp35.i.mail.ru with esmtpa (envelope-from ) id 1qWYtl-001hPG-2c; Thu, 17 Aug 2023 12:02:34 +0300 Date: Thu, 17 Aug 2023 11:57:46 +0300 To: Sergey Bronnikov Message-ID: References: <3e790e17-5ded-48ff-9716-4c32ed5dcdab@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3e790e17-5ded-48ff-9716-4c32ed5dcdab@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9700E0DCE2907754D4D249011687940C6678A0DD020DA6E3B182A05F538085040694C1B8851792A402A36B13D66B21BEAF7BEA8810056B9118E5A6C6340867D2D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73B44982FA5E78411EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B100969577675F2D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D86B40FAAF74B63F159327A4F5F8E1669E117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC317C7E487E00003AA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18F04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE0AC5B80A05675ACD9935A1E27F592749D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3F8BD4E506CFA3D88C0837EA9F3D19764C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407978DA827A17800CE7649B83402744A6742DBA43225CD8A89F616AD31D0D18CD5C57739F23D657EF2BB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A53E4D1B4247F39BABCA006EF82F599A0CA53FAAFAEFEB1E04F87CCE6106E1FC07E67D4AC08A07B9B0E753FA5741D1AD02CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34DA1FE609583D493C6071C2775179D19CC0CF43E7B48F39865B99F1BBA3E869F1EEEA9345DD482A8E1D7E09C32AA3244C57F172B9481EFE9A7689B5A4CA0A93D9A8CE788DE683120585A42E4C463514DC5DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojFRrmMqSMPxqyG6GHKSmGbg== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A76941420C29E3BA38902A36B13D66B21BEA21401CF93FD6FA55DEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 15/19] Fix LJ_MAX_JSLOTS assertion in rec_check_slots(). X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! On 17.08.23, Sergey Bronnikov wrote: > Hi, Sergey! > > On 8/9/23 18:36, Sergey Kaplun wrote: > > From: Mike Pall > > > > Thanks to Yichun Zhang. > > > > (cherry-picked from commit 1c89933f129dde76944336c6bfd05297b8d67730) > > > > This patch is predecessor for the commit > > 944d32afd6ddd9dbac1cddf64bf81333efeb9e30 ("Add missing LJ_MAX_JSLOTS > > check.") It tries to fix the issue, when `J->baseslot == LJ_MAX_JSLOTS`, > > that leading to the assertion failure. Since the predecessor patch, > > there are no places, that can lead to the condition failure, since we > > always check that new baseslot + framesize (+ vargframe) >= > > `LJ_MAX_JSLOTS`. As far as minimum framesize is 1 (see > > for details), we can't obtain this assertion failure. This patch is > > added for the consistency with the upstream. > > > > Since the predecessor patch fixes the issue, there is no new test case > > to add. > > > > Sergey Kaplun: > > * added the description for the problem > Test for backported patch is missing. Why? As mentioned above there is two separate commits (the current one and this one [1]). Since the second fixes the issue and was backported earlier there is no new testcase provided (see the commit message). > > > > Part of tarantool/tarantool#8825 > [1]: https://github.com/LuaJIT/LuaJIT/commit/630ff319 -- Best regards, Sergey Kaplun