From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 556F3581FDB; Thu, 17 Aug 2023 11:05:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 556F3581FDB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692259556; bh=L+Oa2M/mKbR5LS1SzlyW3ntph6nmzgTq3juIr8lor04=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=KgS1MEYEs5Kn6Q9+EeO0qMTBKQr5P5GMrdC0jrl2xu4yFv73zZPo/e/wkgmG9pqXG a9TgGXu03VDqpUzWWtgwaMrwqhHbF39f6UZ3wGnq5+5MFe7cSm06Vm+g/0uI+WynF8 COld9EDnlK89rxsKpDWzv5x2arWD53TmISwtbg0w= Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [95.163.41.90]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1F753581FDB for ; Thu, 17 Aug 2023 11:05:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1F753581FDB Received: by smtp53.i.mail.ru with esmtpa (envelope-from ) id 1qWY0w-009mo8-11; Thu, 17 Aug 2023 11:05:54 +0300 Date: Thu, 17 Aug 2023 11:01:07 +0300 To: Sergey Bronnikov Message-ID: References: <3166f89d23b9986f3849f2873ee78285c034b894.1691592488.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9700E0DCE2907754D065B653CA1E56B5DB3B38B4431605699182A05F538085040AA81B66FA693052829195D514AE79F55E87CC9C13DED7F1CB416911598779FD2 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7495A032B936E882FEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063745476ED688D943148638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8808F14EB70CA44FBBAF1A447EC227EF9117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3D2201D7125A9A9FA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520140C956E756FBB7AC26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE0AC5B80A05675ACDC766E17BBE5724E9D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3F8BD4E506CFA3D88AD7EC71F1DB88427C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947C2FFDA4F57982C5F42E808ACE2090B5E1725E5C173C3A84C3E97D2AE7161E217F089D37D7C0E48F6C8AA50765F79006377F02F59195295693EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A57130A7739E5227ECBE0A73BD7B432AEFFC72FAD20FC545BAF87CCE6106E1FC07E67D4AC08A07B9B0457EE4B4996FC546CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3453741B480A6503C3058432AED44C4997D067B09D9206C9CDCC74ED6EE68B49C9D3792A22EB80DF001D7E09C32AA3244C3768289E8D1A9332E984E6ABE0D2C1F333C9DC155518937FBAD658CF5C8AB4025DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojFRrmMqSMPxpXPbbWebOw9Q== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769572A6D149B283DC529195D514AE79F55BC4EE72AB2E748C5DEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 13/19] ARM: Fix GCC 7 -Wimplicit-fallthrough warnings. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! On 17.08.23, Sergey Bronnikov wrote: > Hi, Sergey! > > LGTM, but I have a question inline > > > > + AND CMAKE_C_COMPILER_VERSION VERSION_GREATER_EQUAL "7.1") > > GCC 7.1 because there was no 7.0 in release series 7 [1], right? > > 1. https://gcc.gnu.org/gcc-7/ Yes, just the first version with this option. -- Best regards, Sergey Kaplun