From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 818CF55961F; Wed, 2 Aug 2023 11:25:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 818CF55961F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1690964756; bh=ijOldD8Bdu73glX2x0PkB/aFMLcUvnfBjc9c0GBE1eQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ci/GUf64KMf/RnHT1nJOipAYHGEqwOy5lqtEF01cuNwvbTveSFgSrP4AUtJOb/js7 SvNO9v8hpjAsbyBr531ZdH+HF0TxwrrVVKWLbB9TEp5v1XQdszQJbh1Vhe+CjjPz1w KwI97uEvAIYN+mz48fIwO6uzo6a/i4FTRqBPE1W0= Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [95.163.41.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id F28A9559602 for ; Wed, 2 Aug 2023 11:25:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F28A9559602 Received: by smtp33.i.mail.ru with esmtpa (envelope-from ) id 1qR7B4-00GpX3-0c; Wed, 02 Aug 2023 11:25:54 +0300 Date: Wed, 2 Aug 2023 08:12:50 +0000 To: Maxim Kokryashkin Message-ID: References: <20230710112400.1802-1-max.kokryashkin@gmail.com> <2e5eayfduee7hlxwdd2fthtgg4aibmohyc5ti7hcskpzswkv5y@t5eoedfsqx2n> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2e5eayfduee7hlxwdd2fthtgg4aibmohyc5ti7hcskpzswkv5y@t5eoedfsqx2n> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD93761F2630DFFAF416DDF8A3A1F98730F81C7E6AA5A500726182A05F538085040BC42E6A600814E8FB6643447FDF2CA5FFE24DA9980F6CB59120624AED69F8173 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE790A429F79E911BC3EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376F978168E59B07A5EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BE5CCB53A13BC8DBA51A0BE2DC0CD34ED3857E4B77DE3BEAECC7F00164DA146DAFE8445B8C89999728AA50765F7900637F3E38EE449E3E2AE389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC84AB4081B6A6C2E07F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C67F1C1C3ABB44F3A6E0066C2D8992A164AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3302A61B22DEE7324BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF17B107DEF921CE791DD303D21008E298D5E8D9A59859A8B6D082881546D9349175ECD9A6C639B01B78DA827A17800CE77DCDFB3399A2F72843847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5B6019B8C488578939D256310159875F0E084E01C8DFB4349F87CCE6106E1FC07E67D4AC08A07B9B04B6F6234D9065C97CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFA5C01639C8E97DD48ECC23D27827A6F784C5BEE540228390480B2A7B72D36EAEAE7801A017AB3E4A8553022043D0BC9A91B12E0100E123BF155428617E51CE8F461A413F07889F2102C26D483E81D6BEECAEF3E2CCC1ED8C383653B6C8D9AE0FD16FCAA6493B703A X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojV0vAgLNnFuekc3iL1nbkbg== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D531BFE6B8BCCD252D958B0696428A88C881E91E5C0C426EA6BC2326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v7] memprof: introduce cli flag to run dump parser X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: Maksim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, On 02.08.23, Maxim Kokryashkin wrote: > Hi, Igor! > > Well, I see no obstacles with flag handling in Tarantool. > For instance, the -j flag proxy can do exactly what you want. > > | review/tarantool/build fckxorg/gh-5688-cli-for-memprof-parse ✔ 239d16h > | ▶ ./src/tarantool -j on -e 'print(jit.status())' > | true fold cse dce fwd dse narrow loop abc sink fuse > | > | review/tarantool/build fckxorg/gh-5688-cli-for-memprof-parse ✔ 239d16h > | ▶ ./src/tarantool -j off -e 'print(jit.status())' > | false fold cse dce fwd dse narrow loop abc sink fuse > My bad, I'm concerted rather about this difference and its effect in Tarantool flags processing: | $ ./luajit -bl -e 'print("qq")' | -- BYTECODE -- "print("qq")":0-1 | 0001 GGET 0 0 ; "print" | 0002 KSTR 1 1 ; "qq" | 0003 CALL 0 1 2 | 0004 RET0 0 1 | | $ cd ../src/tools | $ ../src/luajit -tm -e 'print("qq")' | luajit-parse-memprof.lua: ERROR: unrecognized option `-e'. Try `--help'. | In other words, I wonder * whether flags in Tarantool are position independent (i.e. the result of -j + -e combination equals to -e + -j); * how --leak-only will be handled in this case. BTW, I have a thought regarding introducing kinda "mode" for memprof, so we can use it like -tm=leak-only (as an alternative to the original proposal in the first message). Besides, I see no tests for --leak-only (have no idea, why everyone missed this on review). Could you add them? > Tarantool's flag handling is not pleasant to say the least, > but we should try to do the same as with -j. > > Best regards, > Maxim Kokryashkin > > > On Wed, Aug 02, 2023 at 07:23:03AM +0000, Igor Munkin wrote: > > Max, > > > > We've discussed with Sergey K. how to run -tm with --leak-only today. > > Fortunately, it works fine in LuaJIT, however, I'm afraid such flag > > handling in incompatible in Tarantool. Hence, I suggest to glue this > > flag with comma to -tm, like jdump does[1]. Thoughts? > > > > [1]: https://github.com/tarantool/luajit/blob/tarantool/master/src/jit/dump.lua#L18 > > > > -- > > Best regards, > > IM -- Best regards, IM