From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1AF6554AE27; Wed, 26 Jul 2023 16:18:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1AF6554AE27 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1690377516; bh=MYTKWAVObnfB9zbaocBzy7UBUC7NEXmoPx4DUksaFj0=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=iRNmRhX4loVltUoR35u+7OqTap/29Ncoi/5vZU74o1+3gHIXYDWKVf2G7sO+TilJA a09SX9wzyBiXqcXdv7SlrZMTW6+T9fmK8OIfHT64oGsCXi8iaGt1bKJEyd5w9hd7S5 SRbeZ7EUb/PxsN1n2bVTSMk5OlOhbyqz5xxM80vA= Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [95.163.41.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B8EFE543BF5 for ; Wed, 26 Jul 2023 16:18:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B8EFE543BF5 Received: by smtp49.i.mail.ru with esmtpa (envelope-from ) id 1qOePR-00Bp1s-Tl; Wed, 26 Jul 2023 16:18:34 +0300 Date: Wed, 26 Jul 2023 13:06:29 +0000 To: Sergey Bronnikov Message-ID: References: <1330e6f3-18f1-c180-9de5-3db1fd52757c@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1330e6f3-18f1-c180-9de5-3db1fd52757c@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9F4F4431F26286E461E8909B71F218E36BE65B9850231FD28182A05F5380850400940DD84AB6EFE42988DCA246858239E57D8A93B67457394B74781A1BCBD8218 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70A10A23A3B64B805EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CE17C7754E00FC028638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D843EDCFD2A5E7D590272648E8FF88EF32117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520CCD848CCB6FE560CF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C67F1C1C3ABB44F3A6E0066C2D8992A164AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3302A61B22DEE7324BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CFC5EA940A35A165FF2DBA43225CD8A89FB26E97DCB74E6252156CCFE7AF13BCA4B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A54CAE163CFBB2835E9941D3AD8804592402499D2599A6F5DDF87CCE6106E1FC07E67D4AC08A07B9B08ED1AC82D843A2BBCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF64C6F25996E1777706D1335CD177460C9068C40C65BBE2C347FE7E77D433BD2280BEFAEC9D2720082D8A5E5B53F5BD04A279837E15D1752F7DBF0E80934AFFD5A74DFFEFA5DC0E7F02C26D483E81D6BEECAEF3E2CCC1ED8C383653B6C8D9AE0FD16FCAA6493B703A X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojXeYlEwgoYE9G7duLTIOoig== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D53147D25C646ABBAC4B60A58B9252BDB1EAB98E25DE38F3D98E2326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2 4/5] build: introduce LUAJIT_USE_ASAN option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for your review! See my answers below. On 24.07.23, Sergey Bronnikov wrote: > Thanks for the patch! See comments below. > > > On 7/21/23 11:12, Igor Munkin wrote: > > +# ASan enabled. > > +option(LUAJIT_USE_ASAN "Build LuaJIT with AddressSanitizer" OFF) > > +if(LUAJIT_USE_ASAN) > > + if(NOT LUAJIT_USE_SYSMALLOC) > > + message(WARNING > > + "Unfortunately, internal LuaJIT memory allocator is not instrumented yet," > > + " so to find any memory errors it's better to build LuaJIT with system" > > + " provided memory allocator (i.e. run CMake configuration phase with" > > + " -DLUAJIT_USE_SYSMALLOC=ON)." > > + ) > > + endif() > > + # Use all recomendations described in AddressSanitize docs: > > typo: recomendations -> recommendations Fixed, thanks! > > > With applied patch tests below failed: My bad: I've made inaccurate rebase on the bleeding master and forgotten to update tests added by Max and Sergey. See the iterative diff: ================================================================================ diff --git a/test/tarantool-tests/lj-1024-varg-maxslot.test.lua b/test/tarantool-tests/lj-1024-varg-maxslot.test.lua index e33ddba2..81fb1eea 100644 --- a/test/tarantool-tests/lj-1024-varg-maxslot.test.lua +++ b/test/tarantool-tests/lj-1024-varg-maxslot.test.lua @@ -60,4 +60,4 @@ end test:ok(true, 'BC_VARG recording with VARG slots defined on trace') -os.exit(test:check() and 0 or 1) +test:done(true) diff --git a/test/tarantool-tests/lj-128-fix-union-init.test.lua b/test/tarantool-tests/lj-128-fix-union-init.test.lua index 93cbf3af..b36758fc 100644 --- a/test/tarantool-tests/lj-128-fix-union-init.test.lua +++ b/test/tarantool-tests/lj-128-fix-union-init.test.lua @@ -55,4 +55,4 @@ for i = 1, NITERATIONS do test:ok(union_type(i).u == i, 'first member init only') end -os.exit(test:check() and 0 or 1) +test:done(true) ================================================================================ Thanks for manual testing this, since it was covered by another bug in CI (see the explanation in the next patch). > > -- Best regards, IM