From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DD26054AE17; Wed, 26 Jul 2023 16:06:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DD26054AE17 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1690376800; bh=qpCYtv2u3BDiV5sB+KlCP+25rY9jjcbutoI6O2jKN48=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=cQFfPoMmDTBQ1h/2Bt+ttZvsoAI69oEWxyRm18+MHS9TyIgIi2P0w+WolwYc9vQJl oDtSWf1gZ3FC/cwC0zcGKkfNsRCbh1VhFONxQV8YXwWvl3Qa1ZDhn5CkRllb142nE8 GGY7gA0Jo5vaZ3Hm+g8F6vtE+cPH515SfNIhgGSg= Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [95.163.41.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 275BB543BF5 for ; Wed, 26 Jul 2023 16:06:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 275BB543BF5 Received: by smtp63.i.mail.ru with esmtpa (envelope-from ) id 1qOeDu-006ycP-BK; Wed, 26 Jul 2023 16:06:38 +0300 Date: Wed, 26 Jul 2023 12:54:34 +0000 To: Sergey Bronnikov Message-ID: References: <87f18ea0-679c-3973-acf8-5a3be8b0b035@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87f18ea0-679c-3973-acf8-5a3be8b0b035@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9F4F4431F26286E466178CEDC515C122CB67870645C4742C8182A05F53808504043D29BC32B2B95BE0DC722B4B76E42186E32D37A43BD71AD90D8A285260DE841 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73870E1FF9A049D91EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637040380BD28C1B15C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D867FA515E94D89645DEEAD3336C7CC1E9117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520C65AC60A1F0286FE618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEB28585415E75ADA93DBBCB839D0549ACD8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE367F1C1C3ABB44F3A040F9FF01DFDA4A8C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947C2FFDA4F57982C5F435872C767BF85DA227C277FBC8AE2E8BC6A536F79815AD9275ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A58452990700DB75C700C814C584737C49B6802B788B5AE0B5F87CCE6106E1FC07E67D4AC08A07B9B00A6B3CD6EB70C818BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3475FE4AA98865E23522DE788FB4EEF4AFF95F220EB51D95B7EC0E068CC9C7A09535F2FD672520404B1D7E09C32AA3244C6AD7514DC15DFA364392CE95DCB71BF855E75C8D0ED9F6EEBAD658CF5C8AB4025DA084F8E80FEBD376A4ED3E9341DC2FCD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojXeYlEwgoYE/gi4hmQyVj1g== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D5318B159EDCFD12AD26E184732248556BA89A94E4170B25BA272326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2 4/5] build: introduce LUAJIT_USE_ASAN option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for your review! Please consider my answer inline (though, we've already discussed it offline). On 25.07.23, Sergey Bronnikov wrote: > Hello, again > > > On 7/21/23 11:12, Igor Munkin wrote: > > I suspect we need set in LUAJIT_USE_SYSMALLOC in cmake/luajit.cmake [1] on > next LuaJIT bump, right? Again, all problems come from #3071[1]: lua_State is not closed in scope of the patched in Tarantool. Hence, leaks occur in ASan/LSan reports (even with true given as a second parameter of ). Until this issue is not resolved, LUAJIT_USE_SYSMALLOC will report lots of "false positives" issues (at least, I can't prove that these are real leaks in LuaJIT/Tarantool). I'll change this when #3071 is resolved (the same way it's done for LUAJIT_USE_VALGRIND). Hence, LuaJIT-related ASan checks is relaxed in Tarantool, but we have strong validation in LuaJIT CI. > > Otherwise Tarantool CI will fail. > > > 1. https://github.com/tarantool/tarantool/blob/1cda22aaaf7eb1f0880f4c70f2c79ce27a9604ce/cmake/luajit.cmake#L74-L76 > > > > # --- Main source tree --------------------------------------------------------- [1]: https://github.com/tarantool/tarantool/issues/3071 -- Best regards, IM