From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 925E4543BF5; Wed, 26 Jul 2023 15:54:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 925E4543BF5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1690376047; bh=CmGUaH3rB+g3tpTf6O9wQFPo7Bxx/oJIEuz8i4Z1YTY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=KTx7Kdyh8RcqwSbC5mifR7fshizjnjvhfUzKO8EUirDUb1ACeSPwlDJd0SHiLpO3/ H6i1seVJwmxfcj3gLYjasgPKFsUc/igsNOk/T/rbU15AdKcAfdLysVjId/qYmrgmU7 Oqs68qf7XvapmT4Fgb+gB75fs42ScKlzD5jJted4= Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [95.163.41.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3AE07543BF5 for ; Wed, 26 Jul 2023 15:54:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3AE07543BF5 Received: by smtp46.i.mail.ru with esmtpa (envelope-from ) id 1qOe1l-00245d-AG; Wed, 26 Jul 2023 15:54:05 +0300 Date: Wed, 26 Jul 2023 12:42:01 +0000 To: Sergey Kaplun Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9F4F4431F26286E46B6C81591349CF48065A036C6B0D898E2182A05F5380850406CC4BA3621DDA6B97FDF9D62E056AB48D95C7CF8DFD6D92ED45BEF5B442BBEA6 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7876E9C5582D2D91DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371E8C7BD479B346ED8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8E48B7BA7ED285F4AE7BE407058494BEC117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520437C869540D2AB0F28451B159A507268D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEB28585415E75ADA9C5236E9430F51F07D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3AD74539164518AE52D242C3BD2E3F4C6C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735B17145F0B7815491C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5A230FE8FE0FC46E8C6CF8A1A18057427A45DC9717D4D2783F87CCE6106E1FC07E67D4AC08A07B9B0FE4D9CDE3FF759CFCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF187EA4613A58DD0F85B937B7D8A3F6DD4F0CF8233993A2D4885EB6FAB69E8F06500AA17B1AA25A4F2D8A5E5B53F5BD04154D8387133BB60DE0C32D76EFEED1CDA74DFFEFA5DC0E7F02C26D483E81D6BEECAEF3E2CCC1ED8C383653B6C8D9AE0FD16FCAA6493B703A X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojXeYlEwgoYE9Nnt4Wm/ADDA== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D531721251A349EE12D33714D740513563C332871ABCB566BFD02326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2 3/5] test: introduce test:done TAP helper X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for your review! Fixed all the typos you've found. On 26.07.23, Sergey Kaplun wrote: > Hi, Igor! > Thanks for the patch! > LGTM, except a minor nits regarding the commit message. > > On 21.07.23, Igor Munkin wrote: > > +local function done(test, exit) > > + if exit then > > + -- XXX: The second argument is required to properly close Lua > > + -- universe (i.e. invoke before exiting). > > + -- XXX: return is added explicitly to force CALLT emitting. > > Side note: Is there a place, where it is important? No, there's not. Prosto po prikolu. > > > + return os.exit(test:check() and 0 or 1, true) > > + else > > + assert(test:check(), 'Test check failed') > > + end > > +end > > > > > -- > > 2.30.2 > > > > -- > Best regards, > Sergey Kaplun -- Best regards, IM