From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 3A8C3597C0C; Sun, 6 Aug 2023 14:14:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3A8C3597C0C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1691320456; bh=GKafspKyHIavbPctDcgH/44zYrTe1zSn7ryHzpw6p58=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=aVLUs8E5FLGPwGH1vBOhXBRAlxqXWyVmw9FdUZwmgf/caygj89Uyohs5uH/lnzG0v HeTJVO/7uEevJrMbBJq460BLhOUMtWopVNcCrJ7GvGunGEHJONS2NTJE6t8+rHMt1u w3BATFMxJKvYDwKnA3Wg/j16hgiDXGyA94txtKx4= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6F9074A9481 for ; Sun, 6 Aug 2023 14:14:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6F9074A9481 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1qSbi9-0007Pm-OG; Sun, 06 Aug 2023 14:14:14 +0300 Date: Sun, 6 Aug 2023 14:09:27 +0300 To: Maxim Kokryashkin Cc: Sergey Bronnikov , tarantool-patches@dev.tarantool.org, max.kokryashkin@gmail.com Message-ID: References: <6426e58a9a72691ccffc84001c21e363c8da6312.1690300762.git.sergeyb@tarantool.org> <5t3vejxwlcpd3fczyenum4527mtwtmt6qd4agwrxhnkt3zdtob@62fmw5pdbhqg> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5t3vejxwlcpd3fczyenum4527mtwtmt6qd4agwrxhnkt3zdtob@62fmw5pdbhqg> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD969E04B5EED670DC8BEB87106826C459512B2000DD660D84D182A05F538085040BC52975232AD90681D4A30AF23470BF8290C73A94747BC53D1B9887B9DF72CC9 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78E8764B5BC580342EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637317AD06F2A8D0AEF8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D888AE21BBF68535D46AE98E980DA771A4117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCECADA55FE5B58BB7A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520C65AC60A1F0286FEF04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BAE9A1BBD95851C5BAAAE862A0553A39223F8577A6DFFEA7CCB4B9D7E49E0773B43847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5CC5FD761EE507A5C76B8EEF85CF2CDE107296839CFE83522F87CCE6106E1FC07E67D4AC08A07B9B064E7220B7C550592CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D341ADA1A41A420E9B2762C68396ED78BA45FAD6AB6B75BB6ED131F97E3DBFDEF1298D087B92F39854D1D7E09C32AA3244C8452E524211813480291C71C6B5FF46030363D8B7DA7DD44BAD658CF5C8AB4025DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojl9DvqjyDU9MzrvNrpV1y5Q== X-DA7885C5: 4B7255D06FCBF70CBB1BDEE040A1183B2B33FAFA476EEAD9CC2D8F843188C3B6262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986BD4116424324437EAE0D4B1740DB2C56A0FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/2] Fix embedded bytecode loader. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Max, Sergey! The patch is LGTM, after adding the test case (without additional CI job, if you don't want), see rational below. On 31.07.23, Maxim Kokryashkin wrote: > Hi, Sergey! > > tests patch partially. > Typo: s/tests the patch/ > > Well, I've tried to run that test on x32 machine, and nothing happened. > I think we should backport this patch without tests then, since this > test seems irrelevant to the problem. What do you think? > > Also, it is kinda strange, that you are talking about a test in a patch > without any tests. You need to either mention that the test is present in > the next commit, or move that test here. The problem is perfectly repoduced for me if use instructions from [1]. I suppose that we should add this test, because it: 1) Shows the problem for the actual build that can be done by the user. 2) Still tests LuaJIT loader. > > > > Sergey Bronnikov: > > * added the description > > --- > > src/lj_bcread.c | 10 +++++----- > > src/lj_lex.c | 6 ++++++ > > src/lj_lex.h | 1 + > > 3 files changed, 12 insertions(+), 5 deletions(-) > > -- > > 2.34.1 [1]: https://github.com/LuaJIT/LuaJIT/issues/549 -- Best regards, Sergey Kaplun