From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D7789597C32; Sun, 6 Aug 2023 14:45:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D7789597C32 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1691322349; bh=hPvY6tD9gxdx3x+0OvfBEjfWvxje7gA3siLg8eHff9s=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=QK/GQBbdhrrZOJCVBxNfiOKC3pe8/DX5L+FA3p2fI3ZyPx3ma03heGiU7cIYu1aMQ m9QXGwgpCi3STJy5NVZ6KzwvvkOHV+4OtXd89i5pM5OmvHT8+CkiOnrETop34xRQwW 8SZWCPWO04yJi9bifWvSaT7JTSGEGB6eMBqrFzLs= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 712A6597C0C for ; Sun, 6 Aug 2023 14:45:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 712A6597C0C Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1qScCh-0004px-Md; Sun, 06 Aug 2023 14:45:48 +0300 Date: Sun, 6 Aug 2023 14:41:01 +0300 To: Maxim Kokryashkin Cc: Sergey Bronnikov , tarantool-patches@dev.tarantool.org, max.kokryashkin@gmail.com Message-ID: References: <6535409abb0242a342285f683db945f54b01e5d2.1690915289.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD969E04B5EED670DC8BEB87106826C4595A10F7F5F18564AA6182A05F538085040DD09BDD55D7F0A5B9A70783C0092F1AB267443F11DA6A25945B09269E2A19E5F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE705B093C0FC4B30B9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637013F392EFFCDE01C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8AB2C1DCDAE78A9EE2C03643694036F49117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735204B6963042765DA4BCB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BF80095D1E57F4578AAAE862A0553A39223F8577A6DFFEA7C1156E5889A6D309143847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5EA05688175E5B923BB071791F6976EB9FB8A0C396758941AF87CCE6106E1FC07E67D4AC08A07B9B062B3BD3CC35DA588CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF699112955F9418C27AD2CA163BA4D6A87820B0012AA27297F480476E237074714C7498080C0F87FC6CFA265C340F28BA473344AAA88B961286873E77BDFAA043A74DFFEFA5DC0E7F02C26D483E81D6BE5EF9655DD6DEA7D65774BB76CC95456EEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojl9DvqjyDU9N1U10KhdGQsA== X-DA7885C5: 672B9F0B58C6F943880CCA387BB4A8F749B11F1B14B72311CA01B7C99BE5864C262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B9D7E44518638B4C6C46BD3BFFE69C2FC0FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 2/2 v2] ci: support coveralls X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim, Sergey! Thanks for the patch and the review! LGTM, just a minor comments below. On 02.08.23, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, except for a few nits regarding the commit message. > > Best regards, > Maxim Kokryashkin > > On Tue, Aug 01, 2023 at 09:46:10PM +0300, Sergey Bronnikov via Tarantool-patches wrote: > > From: Sergey Bronnikov > > > > The patch adds a workflow that runs regression test suites, produces a > > summary about current code coverage and send code coverage data to > Typo: s/about/of/ > Typo: s/send code/sends code/ > > Coveralls. Coveralls is a web-service that lets you inspect every detail > Typo: s/web-service/web service/ > > of your coverage. See Tarantool's LuaJIT page on Coveralls [1]. > > > > 1. https://coveralls.io/github/tarantool/luajit > > --- > > .github/actions/setup-linux/action.yml | 1 + > > .github/workflows/coverage.yml | 60 ++++++++++++++++++++++++++ > > 2 files changed, 61 insertions(+) > > create mode 100644 .github/workflows/coverage.yml > > > > diff --git a/.github/actions/setup-linux/action.yml b/.github/actions/setup-linux/action.yml > > index f0171b83..71619a60 100644 > > --- a/.github/actions/setup-linux/action.yml > > +++ b/.github/actions/setup-linux/action.yml > > @@ -16,4 +16,5 @@ runs: > > run: | > > apt -y update > > apt -y install cmake gcc make ninja-build perl > > + pip3 install gcovr Should it be done in the separate action, like it is done for ASan? Because we don't need gcovr for all our linux testing. > > shell: bash > > diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml > > new file mode 100644 > > index 00000000..9fff06c7 > > --- /dev/null > > +++ b/.github/workflows/coverage.yml > > @@ -0,0 +1,60 @@ > > +name: Code coverage > > + > > +on: > > + push: > > + branches-ignore: > > + - '**-notest' > > + - 'upstream-**' > > + tags-ignore: > > + - '**' > > + > > +concurrency: > > + # An update of a developer branch cancels the previously > > + # scheduled workflow run for this branch. However, the default > > + # branch, and long-term branch (tarantool/release/2.11, > > + # tarantool/release/2.10, etc) workflow runs are never canceled. > > + # > > + # We use a trick here: define the concurrency group as 'workflow > > + # run ID' + # 'workflow run attempt' because it is a unique > > + # combination for any run. So it effectively discards grouping. > > + # > > + # XXX: we cannot use `github.sha` as a unique identifier because > > + # pushing a tag may cancel a run that works on a branch push > > + # event. > > + group: ${{ startsWith(github.ref, 'refs/heads/tarantool/') > > + && format('{0}-{1}', github.run_id, github.run_attempt) > > + || format('{0}-{1}', github.workflow, github.ref) }} > > + cancel-in-progress: true > > + > > +jobs: > > + coverage: > > + strategy: > > + fail-fast: false > > + runs-on: [self-hosted, regular, x86_64, Linux] > > + steps: > > + - uses: actions/checkout@v3 > > + with: > > + fetch-depth: 0 > > + submodules: recursive > > + - name: setup Linux > > + uses: ./.github/actions/setup-linux > > + - name: configure > > + run: > > > + cmake -S . -B ${{ env.BUILDDIR }} > > + -G Ninja > > + -DCMAKE_BUILD_TYPE=RelWithDebInfo > > + -DLUAJIT_ENABLE_COVERAGE=ON > > + -DLUAJIT_ENABLE_GC64=ON Is there a way to joing GC64/non-GC64 testsing? Same for ARM64. > > + - name: build > > + run: cmake --build . --parallel > > + working-directory: ${{ env.BUILDDIR }} > > + - name: test and generate code coverage report > > + run: cmake --build ${{ env.BUILDDIR }} --parallel --target coverage I see no test target here, so will we get the correct coverage results? Am I missing something? If yes, than comment is desirable. > > + - name: send code coverage to coveralls.io > > + run: | > > + curl -LO https://coveralls.io/coveralls-linux.tar.gz > > + tar xvzf coveralls-linux.tar.gz > > + ./coveralls -f ./coverage/luajit.xml > > + working-directory: ${{ env.BUILDDIR }} > > + env: > > + COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }} > > -- > > 2.34.1 > > -- Best regards, Sergey Kaplun