From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 59B7153B848; Fri, 21 Jul 2023 11:27:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 59B7153B848 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1689928051; bh=8Xpb7H55lVFCzja0Dfn73O4rtAaLDmS8nom1RKbaQ8Q=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=hraZWH+Meas+dZbPOfyPp8dkkU9orYsVfOzkHFwcnsG/VGtyUQsWcdG3nDlPsmVbq ZQlf7cLwoa1j2UqmZtYoTuT7f82Co+tHBgZaG9IfmOGhM7EeiE8Ym/KTMY2CuEjM4q dM/28dVlRV9/PMZkHfCBl9PL/bxGb6Z2nGrQgC44= Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [95.163.41.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 61E2053B848 for ; Fri, 21 Jul 2023 11:25:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 61E2053B848 Received: by smtp38.i.mail.ru with esmtpa (envelope-from ) id 1qMlSU-00GYxS-FC; Fri, 21 Jul 2023 11:25:54 +0300 Date: Fri, 21 Jul 2023 08:14:36 +0000 To: Sergey Bronnikov Message-ID: References: <14eab2dd6a619fb33d9b82bd24b4c2515184659d.1689195028.git.imun@tarantool.org> <67552873-63f9-b5af-bd8b-d8c54dcdfc74@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <67552873-63f9-b5af-bd8b-d8c54dcdfc74@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9227D43F3CB451B41C680B045355580F9F91DE19E33172CA4182A05F5380850407568F973293629A0CB187B9514CAF63E94A2DF87D19827B1B288311F08E24A70 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B9FBA884A7C9B8BAEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378D70459430292EC88638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A54D3AF8EFD731C6C074805E793EA0BA117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B7F89A93FC914C3A2A471835C12D1D977C4224003CC836476EB9C4185024447017B076A6E789B0E975F5C1EE8F4F765FC7F4CC751506744793AA81AA40904B5D9CF19DD082D7633A0C84D3B47A649675F3AA81AA40904B5D98AA50765F790063744F53BFAB09560F8D81D268191BDAD3D3666184CF4C3C14F3FC91FA280E0CE3D1A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F3695E42C86E34F97089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A593225FFAD1E965CD2FA3C44775F6AA17DC4265C8AFC2976DF87CCE6106E1FC07E67D4AC08A07B9B00A6B3CD6EB70C818BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D340B06C327CE4A70E8FF4429CC45625F10034CC0380866480D48214BEE2C745799FC8480B40D3184F41D7E09C32AA3244C4E538FA48B5DB41C78C5A7BE9520089795A9E0DC41E9A4CFBAD658CF5C8AB4025DA084F8E80FEBD376A4ED3E9341DC2FCD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojhjdY/2lpWUJ3LEtUGsLwUw== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D53197EF031EF263D06247354A525EBF39DB1B022678D1B5C5C92326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] ci: introduce testing workflow with sanitizers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! See my replies below, and the second version of the series[1] for updates. On 13.07.23, Sergey Bronnikov wrote: > Thanks for the patch! LGTM with minor comments below > > Sergey > > On 7/13/23 00:09, Igor Munkin wrote: > > This commit adds GitHub workflow running all available LuaJIT tests with > > LUAJIT_USE_ASAN option enabled. For now, sanitizers workflow works only > > for Linux/x86_64 as the most scaling setup in our CI. I believe we will > > be able to add other platforms being supported, when ARM64 and macOS > > beware that ARM64 is absent in a list of supported platforms [1] > > https://clang.llvm.org/docs/AddressSanitizer.html#supported-platforms Thanks for mentioning: removed this from commit message. > > > > > + - name: test > > + env: > > + # Enable as much checks as possible. See more info here: > > However, some checks are *disabled*, for example "print_suppressions" > > and "heap_profile" are disabled. Is it intentionally? "print_suppressions" is disabled intentionally, to not spoil the output of the test; "heap_profile" is also disabled in Tarantool, and it is experimental, so I'm afraid introducing flaky failures when enable it. If you can suggest particular flags to be enabled, feel free to share in the second version of the series[1]. > > > + # https://github.com/google/sanitizers/wiki/AddressSanitizerFlags > there are also LeakSanitizer flags here > https://github.com/google/sanitizers/wiki/AddressSanitizerLeakSanitizer#flags > > + ASAN_OPTIONS: " \ > > + detect_invalid_pointer_pairs=1: \ > > + detect_leaks=1: \ > > + detect_stack_use_after_return=1: \ > > + dump_instruction_bytes=1: \ > > + heap_profile=0: \ > > + print_suppressions=0 \ > > + symbolize=1: \ > > + unmap_shadow_on_exit=1: \ > > + " > > + run: cmake --build . --parallel --target LuaJIT-test > > + working-directory: ${{ env.BUILDDIR }} [1]: https://lists.tarantool.org/tarantool-patches/cover.1689925402.git.imun@tarantool.org/T/#t -- Best regards, IM