From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 087E553B849; Fri, 21 Jul 2023 11:27:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 087E553B849 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1689928020; bh=6TmkRqol/hlTBKhiOadqPP5PnTvhHjJWBAOzDVR1O60=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=PTtfOQCjSGsOtmvcmItLfQMK2VF17TXl/o+odSmW3T0JbI/mgvVj4LFYPFk4T+5P1 16M4MxqXv09ycCa5w3qPtMqRbMDNfqEN3X8wq5Mw7o8DclTNzoBeBk4wkLRZOIS9MW 0dX8KdRnW5AvGdCRlmb574ZepwcPpLEfeo5B691o= Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [95.163.41.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 21CDC52B8ED for ; Fri, 21 Jul 2023 11:25:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 21CDC52B8ED Received: by smtp44.i.mail.ru with esmtpa (envelope-from ) id 1qMlRi-005wVr-92; Fri, 21 Jul 2023 11:25:06 +0300 Date: Fri, 21 Jul 2023 08:13:48 +0000 To: Sergey Kaplun Message-ID: References: <14eab2dd6a619fb33d9b82bd24b4c2515184659d.1689195028.git.imun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9227D43F3CB451B41616FC75AC98AB10873760FAF3730B0E5182A05F5380850408AE4FAF97A217A05D8B8CEFB3B1FC19334523335E4E35DDDBB3E5050F83A8A0E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE742D9BD90C58D50E0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637782358EF9635990EEA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BE5CCB53A13BC8DBA08C07725E4A404B4E45DB0CD3726E996CC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8EE16715F795C715CF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CF8BD4E506CFA3D886E0066C2D8992A164AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3BED8D3449C78C548BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7A3CCBC2573AEBDE1C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5C230DCC4B0D5B9046F0B089B4327A3CD826756C30D189081F87CCE6106E1FC07E67D4AC08A07B9B02A336C6518635091CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3473688ED311681BF0980CD21C4575CCA8342B0D93F0A28A7EA2FE44395386597F15AE938E442FCAAA1D7E09C32AA3244CA004068591E577AE2C7DB6923879B11497FE24653F78E668BAD658CF5C8AB4025DA084F8E80FEBD376A4ED3E9341DC2FCD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojhjdY/2lpWUJc68UCBAUORw== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D5313F9EC7BB3A6627A34A1C50AEB8C121372513A978B9AF0A4B2326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] ci: introduce testing workflow with sanitizers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for your review! On 13.07.23, Sergey Kaplun wrote: > Hi, Igor! > The patch LGTM as general, just a single note, also mentioned by Sergey > offline: > > Should we also enable LUAJIT_USE_SYSMALLOC for our CI workflow to make > the ASan instrumentation usefull? I added the warning in CMake, if LUAJIT_USE_ASAN is enabled without LUAJIT_USE_SYSMALLOC, and enabled it in CI. See the second version of the series[1] for updates. > > On 12.07.23, Igor Munkin wrote: > > This commit adds GitHub workflow running all available LuaJIT tests with > > LUAJIT_USE_ASAN option enabled. For now, sanitizers workflow works only > > for Linux/x86_64 as the most scaling setup in our CI. I believe we will > > be able to add other platforms being supported, when ARM64 and macOS > > runners starvation is defeated. There is also a separate GitHub Action > > introduced for convenient setup of the environment. > > > > Follows up tarantool/tarantool#5878 > > > > Signed-off-by: Igor Munkin > > > > > > > -- > Best regards, > Sergey Kaplun [1]: https://lists.tarantool.org/tarantool-patches/cover.1689925402.git.imun@tarantool.org/T/#t -- Best regards, IM