From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 81E3253E46F; Thu, 20 Jul 2023 21:49:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 81E3253E46F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1689878963; bh=WkrxDJY0KgcAShpoTg3NNagc+VNcxJeaBAQAHUbJO2I=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=RjLC/3/EtotWvRdjqAwGSmbn+an9Efc6AJLeM66pN4ZuA0tL4agnlvHLJXWRiZvcS Sg8wo05H/Ah754rqnjw3aLMmWAJoY8f2IfEzBbEmNyhdo9BCPC1wE9WlJQSrB0zUhK z2iysqYas/Q62HBmjXXH2diaF9AGImlNXda2tO0k= Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [95.163.41.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A09CD53E447 for ; Thu, 20 Jul 2023 21:48:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A09CD53E447 Received: by smtp59.i.mail.ru with esmtpa (envelope-from ) id 1qMYha-004Mm9-QG; Thu, 20 Jul 2023 21:48:39 +0300 Date: Thu, 20 Jul 2023 18:37:25 +0000 To: Maksim Kokryashkin Message-ID: References: <20230710155624.70639-1-max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230710155624.70639-1-max.kokryashkin@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9227D43F3CB451B41B68166EA724BD6673DA65C860E999803182A05F5380850409EBCF0313C23138D6EFD43E97D32F57C550115E38CDAE2FD1F818C4D6C433577 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70043D879A87EF1BCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379428F6EA0D091379EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BE5CCB53A13BC8DBACA44FF8784A20E59189812AA07F7BF98CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637E8411255775BB20C389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F7900637F8DB709AF5FDCF73D81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE7622BBA429E6EB97AEC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C30AE2CC35261D99CA75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-B7AD71C0: BCAA75B3C340DBBEEF3A853C90EA8D50F01536074D6990B7EE9D5CB6078CC77CEEB425D5359F6F569016E28473A56E49 X-C1DE0DAB: 0D63561A33F958A5404963160EB06EB447E183F9A711932FB7AF29B8E8DFAFC4F87CCE6106E1FC07E67D4AC08A07B9B062B3BD3CC35DA588CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC71106E36FF2641B7B8424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D346B71C4B0698719D751FFD9904E3F7B69B18413C2AD6E1472CC5A3F4B5BB360BDE7AB1679820A8F011D7E09C32AA3244C70343C4CAB9ECA276BCC1CA1BD2C4A5830363D8B7DA7DD44ED9A463B7D0AAFF65DA084F8E80FEBD376A4ED3E9341DC2FCD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojGEBeBQ0LqGbeMbDjz+dVgQ== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D531AE5DA4BE57C67D4F78850282C93FDEC446DDA3E9626043AC2326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] FFI: Fix recording of union initialization. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the patch! I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/2.11 and release/2.10. On 10.07.23, Maksim Kokryashkin via Tarantool-patches wrote: > From: Mike Pall > > Thanks to Alex Shpilkin. > > (cherry-picked from commit 56c04accf975bff2519c34721dccbbdb7b8e6963) > > As stated here[1], only the first field of a union can be > initialized with a flat initializer. However, before this > patch, on-trace initialization instructions were emitted > for other union members too, overwriting the previous > initialization values. > > This patch fixes the mentioned behavior by preventing > initialization of members other than the first one. > > [1]: https://luajit.org/ext_ffi_semantics.html#init > > Maxim Kokryashkin: > * added the description and the test for the problem > > Part of tarantool/tarantool#8825 > --- > Branch: https://github.com/tarantool/luajit/tree/fckxorg/lj-128-fix-union-init > PR: https://github.com/tarantool/tarantool/pull/8867 > Original LuaJIT PR: https://github.com/LuaJIT/LuaJIT/pull/650 > > src/lj_crecord.c | 5 +++++ > .../lj-128-fix-union-init.test.lua | 18 ++++++++++++++++++ > 2 files changed, 23 insertions(+) > create mode 100644 test/tarantool-tests/lj-128-fix-union-init.test.lua > > -- > 2.39.2 (Apple Git-143) > -- Best regards, IM