From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C716A53D9EF; Thu, 20 Jul 2023 21:48:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C716A53D9EF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1689878903; bh=zH4noZonLqN8dKv25IB5IT0m2esvayNkPMANtPvdVB0=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=QmTbw7xPx6hDZ8bfs6O3XmukYOHWIE8aVouJ3A2aOMNTZoqOXitDKEjn+pmHF1+uO zB/hgaCSuNJfYKdjPpQBiJs1V3Y7ACgnWAwdc3PKP7vLHn+bnJ5eYUray1cJc00LTH oz5b2SzovAqxD43fkmV5RRrX5oM47n5sMxTbpZuw= Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [95.163.41.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7CA8B53D9EF for ; Thu, 20 Jul 2023 21:48:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7CA8B53D9EF Received: by smtp63.i.mail.ru with esmtpa (envelope-from ) id 1qMYhJ-000FEQ-H3; Thu, 20 Jul 2023 21:48:21 +0300 Date: Thu, 20 Jul 2023 18:37:08 +0000 To: Sergey Bronnikov Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD934D79E090D608E19FACDEAA14F13C942F3CE58EDC8F252321313CFAB8367EF908E2BE116634AD74D6F2F5B5EA18F1B4DA3A81D3A97924326AA17B760ED146B615C3268B322D90CF0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AD2F2D6F6013FF7FC2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7B7733D0215A2F71AEA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BE5CCB53A13BC8DBAAA434DDD5893F82A0FCC25E136040419CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637DEC0E67E5F520E81389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F79006376F932D9AE36437A6D81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE75BFB7FB8427AD4CAEC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C30AE2CC35261D99CA75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A561D860FFEFF5F5DF264C5BC2DB704CAE2A704859D5D09F5EF87CCE6106E1FC07E67D4AC08A07B9B0A6C7FFFE744CA7FBCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF77DD89D51EBB7742D3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF14435F2BA480EFC3C127CA31E4B72C901FD78019C261ED427CEAA0CE04620FB1C6BFA615E6C3782A7A512D943FCE53BF35B82C42A9436C2C82EAEAFB1B0726C8A74DFFEFA5DC0E7F02C26D483E81D6BEECAEF3E2CCC1ED8C383653B6C8D9AE0FD16FCAA6493B703A X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojGEBeBQ0LqGZJA5iq4YZjiw== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D531AE5DA4BE57C67D4F66F72D803FAC0C1599D256EB3BFD87EF2326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v1] Fix BC_UCLO insertion for returns. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! FYI, I changed Co-authored-by tag to Helped-by, since the only author of the patch is Mike Pall. I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/2.11 and release/2.10. On 30.05.23, Sergey Bronnikov via Tarantool-patches wrote: > From: Sergey Bronnikov > > Contributed by XmiliaH. > > (cherry-picked from commit 93a65d3cc263aef2d2feb3d7ff2206aca3bee17e) > > After emitting bytecode instruction BC_FNEW fixup is not required, > because FuncState will set a flag PROTO_CHILD that will trigger emitting > a pair of instructions BC_UCLO and BC_RET (see ) > and BC_RET will close all upvalues from base equal to 0. > > Sergey Bronnikov: > * added the description and the test for the problem > > Signed-off-by: Sergey Bronnikov > Co-authored-by: Sergey Kaplun > --- > Branch: https://github.com/tarantool/luajit/tree/ligurio/gh-819-fix-missing-uclo > PR: https://github.com/tarantool/tarantool/pull/8689 > > src/lj_parse.c | 2 +- > .../lj-819-fix-missing-uclo.test.lua | 27 +++++++++++++++++++ > 2 files changed, 28 insertions(+), 1 deletion(-) > create mode 100644 test/tarantool-tests/lj-819-fix-missing-uclo.test.lua > > -- > 2.34.1 > -- Best regards, IM