From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8B8635278FE; Sat, 15 Jul 2023 18:16:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8B8635278FE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1689434179; bh=Et+vAv7hkX3ocEZTDw/zlerIphyEP1fsCZHMfw+srF4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=sWEhRFzBUz1AGV/UQyUvo4ET7xtgReMPo90jE5Uyz/wAk2CziBo0Q+zXuwcVvXb8G AYvsTCU6zebIXyki9PSnQ7v3tx/e4+APjLHYan9xgZWnB33sMkasahg4+XWIS+hNuI XykvoLkWAPKxm2e9VJozVn/5GQXQ/NW4LQ0V5Uvs= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2A60B47F90E for ; Sat, 15 Jul 2023 18:16:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2A60B47F90E Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1qKh0M-0007EP-Fd; Sat, 15 Jul 2023 18:16:18 +0300 Date: Sat, 15 Jul 2023 18:11:55 +0300 To: Maxim Kokryashkin Message-ID: References: <323f1c0c6a33a31f0ad7691bd68886bfd195eae4.1688985402.git.skaplun@tarantool.org> <1689336972.626611927@f763.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1689336972.626611927@f763.i.mail.ru> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD97569A0FE902DCB3DE03C3B2C77D958899BDBCA020D4EBE681867C24CE74E72BB5FE18E9CBFBE7C071E0A1E8D19611B9A352AFC4593BA2D814A34E7D3A00950614B72E82432766FBE X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73B2A9F8A35432468EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006373745FD4183B699148638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D80629C5A6084DA5285EA2D2C90E58D396117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B317C7E487E00003AA471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C565C1E6824D8037B43847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A524D9A0BEF8404D3D0F8E0FC2406C6592A21BB078BDC854ECF87CCE6106E1FC07E67D4AC08A07B9B064E7220B7C550592CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34F38194B2C99DC128DFC5A7C1EAC65723688CE7D3C7C1B96CFCF66D5EFB5248DC6C5ADE8A02CE75151D7E09C32AA3244CC44A8BCC4EA06344FFA16A7869003399D9ADFF0C0BDB8D1F85A42E4C463514DC5DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojTPX5czuwuGF2PX50YYA5Bw== X-DA7885C5: 96052B24E40BB2D69FF05BE2930BF29E8F59CBF4671FCE267F24D90CD445E710262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B9B2DF84214C00217CCD174DE226B98ED0FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] Fix maxslots when recording BC_VARG. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! Fixed your comments! Branch is force-pushed. On 14.07.23, Maxim Kokryashkin wrote: > > Hi! > Thanks for the patch! > LGTM, except for a few nits regarding the commit message. >   > >  > >>From: Mike Pall > >> > >>Analyzed by Sergey Kaplun. > >> > >>(cherry-picked from commit 94ada59628dd6ce5d6d2dad1d35a68ad30127f53) > >> > >>While recording BC_VARG `J->maxslot` isn't shrunk to the effective stack > >Typo: s/shrunk/shrinking I meant the third form shrink/shrank/shrunk here. Ignoring. > >>top. This leads to dead value stored in the JIT slots and the following > >Typo: s/value/values/ Fixed. > >>assertion failure for these slots check in `rec_check_slots()`. Note, > >>that `rec_varg()` modifies `maxslot` only under the condition that > >>`maxslot` should be increased, but the dead values are left for the > >>opposite case. > >> > >>This patch removes the condition inside `rec_varg()` only for the case > >>when varargs are not defined on trace (`framedepth` is 0), but the > >>similar issue still occurs for the case when vararg are defined on the > >Typo: s/vararg/varagrs/ > >>trace. Fixed. > >> > >>Sergey Kaplun: > >>* added the description and the test for the problem > >> > >>Part of tarantool/tarantool#8825 > >-- > >Best regards, > >Maxim Kokryashkin -- Best regards, Sergey Kaplun