From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2FA90527EE7; Fri, 14 Jul 2023 14:58:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2FA90527EE7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1689335904; bh=6NesbE9K8bFh7gn5BNdp1MHdZ1M7Jv/MXQkQlN2qcj0=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=nBMxZCDnz3ZgEg5IpV+SPXhMlKoFOyz8udUHsNd2oHXX3OPQxUZrqfQsYDkVBrpLr oGFWUOj/4W9b7xybu1whsOr+2HuBHpsaI+2HMJkuKsboqOdeMHP1nNUC4UU8qH7p41 edPKW/EkEr5fq+PNPHXlFY6kLoP54OeSmcgDaSus= Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [95.163.41.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 248234F6610 for ; Fri, 14 Jul 2023 14:58:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 248234F6610 Received: by smtp46.i.mail.ru with esmtpa (envelope-from ) id 1qKHRF-00HBnH-Ap; Fri, 14 Jul 2023 14:58:21 +0300 Date: Fri, 14 Jul 2023 14:53:58 +0300 To: Sergey Bronnikov Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9A075ED63965291970CED0DF8012B17C85A461DE8ED8B12B5182A05F5380850408B41BE8A2E429FB0C909B0431B14B0A2A6475FA4E7C9F5703E8DC5ADCF667BAC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F16C4DE526EFCC04EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FD169B9D7A3022168638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D86C3B9F29BF684010922D35C0BAACE2A5117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B0E007FA4003F52FEA471835C12D1D977C4224003CC836476EB9C4185024447017B076A6E789B0E975F5C1EE8F4F765FC4E80449DE5E825373AA81AA40904B5D9CF19DD082D7633A0C84D3B47A649675F3AA81AA40904B5D98AA50765F79006376F7FC77F1E52761BD81D268191BDAD3D3666184CF4C3C14F3FC91FA280E0CE3D1A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F83C798A30B85E16BA91E23F1B6B78B78B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5404C602899C0C275955F8798DB685EDEC549F0D5126FEC92F87CCE6106E1FC07E67D4AC08A07B9B065B78C30F681404DCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFECE0ACFEC7782D02174547ABEBDEE7F668F1507A5EBB6D82EAA4E56B4C7257F368A36B291CE9B2EB7BBDB0A562C82D592533C269CE74293427C2D55F3625D8DBA74DFFEFA5DC0E7F02C26D483E81D6BE5EF9655DD6DEA7D65774BB76CC95456EEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojrC/lX9ZwUYqyevsR9ag/lw== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769062C6073B119C99CC909B0431B14B0A28D2B58C568460B73DEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/2] test: fix typos X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM, except some comments below: 1) I suppose it should be named `refactoring: fix typos`, since we also changed debugger scripts and tools files. Feel free to split this commit into three for each subsystem, but I see no need in this. On 11.07.23, Sergey Bronnikov wrote: > From: Sergey Bronnikov > > Fix typos found with codespell in a files with our own source code. Typo: s/a files/files/ > --- > src/luajit-gdb.py | 6 +++--- > src/luajit_lldb.py | 6 +++--- > test/LuaJIT-tests/src/ctest.c | 2 +- > test/tarantool-tests/CMakeLists.txt | 2 +- > test/tarantool-tests/fix-emit-rma.test.lua | 2 +- > test/tarantool-tests/gh-4199-gc64-fuse.test.lua | 2 +- > .../gh-6096-external-unwinding-on-arm64.test.lua | 2 +- > test/tarantool-tests/gh-6163-min-max.test.lua | 2 +- > test/tarantool-tests/lj-416-xor-before-jcc.test.lua | 2 +- > .../lj-426-arm64-incorrect-check-closed-uv.test.lua | 2 +- > .../lj-512-profiler-hook-finalizers.test.lua | 4 ++-- > test/tarantool-tests/lj-603-err-snap-restore.test.lua | 2 +- > test/tarantool-tests/misclib-memprof-lapi.test.lua | 6 +++--- > test/tarantool-tests/tap.lua | 4 ++-- > test/tarantool-tests/unit-jit-parse.test.lua | 2 +- > tools/memprof/parse.lua | 4 ++-- > tools/memprof/process.lua | 4 ++-- > 17 files changed, 27 insertions(+), 27 deletions(-) > > diff --git a/tools/memprof/parse.lua b/tools/memprof/parse.lua > index d865267b..2c09db90 100644 > --- a/tools/memprof/parse.lua > +++ b/tools/memprof/parse.lua > @@ -52,14 +52,14 @@ local function link_to_previous(heap_chunk, e, nsize) > if not e.primary[heap_chunk[2]] then > e.primary[heap_chunk[2]] = { > loc = heap_chunk[3], > - alloced = 0, > + allocated = 0, > freed = 0, > count = 0, > } > end > -- Save information about delta for memory heap. > local location_data = e.primary[heap_chunk[2]] > - location_data.alloced = location_data.alloced + nsize > + location_data.allocated = location_data.allocated + nsize > location_data.freed = location_data.freed + heap_chunk[1] > location_data.count = location_data.count + 1 > end > diff --git a/tools/memprof/process.lua b/tools/memprof/process.lua > index 0bcb965b..9dc202ae 100644 > --- a/tools/memprof/process.lua > +++ b/tools/memprof/process.lua > @@ -39,8 +39,8 @@ function M.form_heap_delta(events, symbols) > for _, heap_chunk in pairs(event.primary) do > local ev_line = symtab.demangle(symbols, heap_chunk.loc) > > - if (heap_chunk.alloced > 0) then > - dheap[ev_line].dbytes = dheap[ev_line].dbytes + heap_chunk.alloced > + if (heap_chunk.allocated > 0) then > + dheap[ev_line].dbytes = dheap[ev_line].dbytes + heap_chunk.allocated > dheap[ev_line].nalloc = dheap[ev_line].nalloc + heap_chunk.count > end 2) Can we avoid such changes in the not-string/non-comment chunks? > > -- > 2.34.1 > -- Best regards, Sergey Kaplun