From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BA6994F62B0; Tue, 4 Jul 2023 20:21:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BA6994F62B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1688491298; bh=bsTphT11pDIAGIxCvrhmTciJOUUhGuBHcCozqV2ivcc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=TWk1lxkVIknNJOyvAG5HtBpsDhUhpsLTCcapRsI1PFuRBuxUTIl3Ceo18feihkxCX dHUXy1E2JCpBiQY918BMrUrI1abffkhcyO/qDk+vTsf1EoKFaMspurz6SgcsinX9/I oiUKS0o1Uaq7c7IlJ+kjQk2MySefZ9eizC5NQ1XA= Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [95.163.41.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E522D4F62B0 for ; Tue, 4 Jul 2023 20:19:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E522D4F62B0 Received: by smtp50.i.mail.ru with esmtpa (envelope-from ) id 1qGjgZ-00GzNS-RO; Tue, 04 Jul 2023 20:19:32 +0300 Date: Tue, 4 Jul 2023 17:10:40 +0000 To: Sergey Kaplun Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD90EBD74C6BAAC9DBA8968F53F60D5B6C9418AD839521353BE182A05F538085040FF7F89FF84C984DD5437C8F89DDC0800838759125A1C2CBA2DBD7A399811FDCB X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D9C4478D0B876341EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063795AFAF91F541EBCE8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D81A522D42248B73A925A7FBDEFEBF0016117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B972D20C7389F068BA471835C12D1D977C4224003CC836476EB9C41850244470149FD398EE364050F0AC5B80A05675ACD9100238FE36DC7A2B3661434B16C20ACC84D3B47A649675FE827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BB07C9E286C61B7F975ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5AC7DEA9CCEF1F0730776598DE52D3D31E5223D1A9FF733FEF87CCE6106E1FC07E67D4AC08A07B9B0CE135D2742255B35CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D344FDECC3B9E4D57D4BE1D239EAEA69262ED52743A50A9A4BBF13FB456C326A95EA8DA870D4A67E63B1D7E09C32AA3244C8E5C829CD395CB6C17FB8E0F669860D464EE5813BBCA3A9DBAD658CF5C8AB4025DA084F8E80FEBD376A4ED3E9341DC2FCD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojtu6fghEd2rU6sAiKsxV/gA== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D531EDAB15FE90EAF998C7CE2272B3DA5DE55CCCC8CD508BBA3A2326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 0/2] Fix lua_yield from the C hook. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/2.11 and release/2.10. On 22.06.23, Sergey Kaplun wrote: > This patchset fixes the behaviour of the `lua_yield()` invocation inside > C hooks. The first patch fixes the behaviour for non-GC64 mode, but the > GC64 mode is still failing with a core dump. The second patch fixes > behaviour for the GC64 mode as well. > > This patchset is based on the our C tests to be introduced, but their > patch set has 2 LGTMs, so I just checkout this branch from the branch > with C tests. > > PR: https://github.com/tarantool/tarantool/pull/8804 > Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-yield-c-hook > Related issue: https://github.com/tarantool/tarantool/issues/8516 > Mail list: https://www.freelists.org/post/luajit/BUG-Unable-to-yield-in-a-debug-hook-in-latest-21-beta > > Mike Pall (2): > Fix lua_yield() from C hook. > Another fix for lua_yield() from C hook. > > src/lj_api.c | 5 +- > src/lj_ccallback.c | 2 +- > src/lj_err.c | 2 +- > src/lj_frame.h | 2 +- > src/lj_meta.c | 2 +- > .../fix-yield-c-hook-script.lua | 19 +++++++ > .../tarantool-c-tests/fix-yield-c-hook.test.c | 49 +++++++++++++++++++ > 7 files changed, 75 insertions(+), 6 deletions(-) > create mode 100644 test/tarantool-c-tests/fix-yield-c-hook-script.lua > create mode 100644 test/tarantool-c-tests/fix-yield-c-hook.test.c > > -- > 2.34.1 > -- Best regards, IM