From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1BF8A4F62AF; Tue, 4 Jul 2023 20:20:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1BF8A4F62AF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1688491239; bh=AncmvcobCYNSAgyzhj26+kEa25gzmkmgUnyVx2xAviw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Dsl3QAd3mvOEsVhf3HyB0NwyEC0G3b1mZMMSXuTF5x00cYQZIrZg08OSOOm3Q77Za Q1HSza9rmY8EAQtVM2uPVS2baYd+DAeKeTF9NKWGa5mZgNLrk3QItK6s52jJDWE8+I 7rzDH5FfItjyJEZD7QspZbn1zGkEAYEK8H6xlpJI= Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [95.163.41.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 10F694F62BA for ; Tue, 4 Jul 2023 20:19:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 10F694F62BA Received: by smtp48.i.mail.ru with esmtpa (envelope-from ) id 1qGjgK-002DNo-0x; Tue, 04 Jul 2023 20:19:16 +0300 Date: Tue, 4 Jul 2023 17:10:24 +0000 To: Sergey Kaplun Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD90EBD74C6BAAC9DBAB962141B2B1B47D567C03E794E6CF2BF182A05F538085040FC0665BFCCF46F04EE9115CA8B240239D86E9954EEB8FFE7F64824425D499247 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73F64378C139886A6EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375F0BD5CF353A411D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8BF5D18C0CE6EA83641A1DD61E67AF337117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B406C66621D3021AFA471835C12D1D977C4224003CC836476EB9C41850244470149FD398EE364050F0AC5B80A05675ACD4D0DA9BD313A0613B3661434B16C20ACC84D3B47A649675FE827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BAEB924C2B054B06E75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5935CC4C50338E0C807AF78E5BB5933945ADE586EA7C16CD0F87CCE6106E1FC07E67D4AC08A07B9B0DB8A315C1FF4794DBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3450C5E6D685282BA1F1BE2DE83139F51078E311EE7F6AAD3EDC5D1FAC7E996962DFBBBB41D267DC931D7E09C32AA3244CCEC43B3DF6F4788D034277B1E672BE2BF26BFA4C8A6946B8BAD658CF5C8AB4025DA084F8E80FEBD376A4ED3E9341DC2FCD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojtu6fghEd2rXGy0xOj2eOqw== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D531EDAB15FE90EAF99894DFDAC95966DD7F7F72FD02116BEB292326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 0/2] Fix canonicalization of +-0.0 keys for IR_NEWREF. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/2.11 and release/2.10. On 10.05.23, Sergey Kaplun via Tarantool-patches wrote: > The backported commit needs to be checked precisely -- we don't want to > just check that the assertion failures are gone -- some commits [1] may > replace the aforementioned assertions with `return 0` or something else > [2] due to other issues. Hence, we need to be sure that there is no such > IR as "NEWREF.*-0" for these traces anymore. So the first commit > introduces new utility module for tests to parse traces dumped into the > file. There is nothing too fancy -- for now, the returned traces may > only say is there some particular IR or no. Any other features may be > added in the future uses, if we need. > > Q: Can we use `jit.dump()` as is, without temporary file? > A: Yes, but no: > `jit.dump()` may be easily patched to use a custom object as the > second argument, not only file name. But this module dumps trace > information not by lines but more iterative. So we can use the > similar approach as in -- concat each line and only > then dump it. But I don't ready to discuss this opportunity with Mike > now:). So, for now just use a temporary file and remove it after > usage. > > Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-noticket-folding-0 > Taranrool PR: https://github.com/tarantool/tarantool/pull/8634 > Related issues: > * https://github.com/tarantool/tarantool/issues/8516 > * https://github.com/LuaJIT/LuaJIT/issues/981 > > [1]: https://github.com/LuaJIT/LuaJIT/commit/d4c0c6e17ef7edf1f2893bc807746b80612e63e9 > [2]: https://github.com/LuaJIT/LuaJIT/issues/994 > > Mike Pall (1): > Fix canonicalization of +-0.0 keys for IR_NEWREF. > > Sergey Kaplun (1): > test: add utility for parsing `jit.dump` > > src/lj_record.c | 2 + > .../tarantool-tests/lj-981-folding-0.test.lua | 57 +++++++ > test/tarantool-tests/utils/jit_parse.lua | 156 ++++++++++++++++++ > 3 files changed, 215 insertions(+) > create mode 100644 test/tarantool-tests/lj-981-folding-0.test.lua > create mode 100644 test/tarantool-tests/utils/jit_parse.lua > > -- > 2.34.1 > -- Best regards, IM