From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id F31A150971C; Thu, 13 Jul 2023 13:34:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F31A150971C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1689244472; bh=8bfT+usSwmpPyG5dWODsAYOHK2mczuyTL6fu6AiBD24=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=gYu0Ys48UquQ0GU+Jk+TTKcRS67cH9YI+tbwV986KAMsiPvDkXWWFG180D9fX2oSr qU2hO403qPD/z1+/m5Ard5vNCDvRPHKbQmtG7Rwb3qL1yljCyjxl9q1Xl99MFX9rqA 73No1R9U6SjEACHr5o8xiX3WB5/5b3qP6sp/zvAI= Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [95.163.41.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 509434F62AF for ; Thu, 13 Jul 2023 13:34:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 509434F62AF Received: by smtp63.i.mail.ru with esmtpa (envelope-from ) id 1qJteY-009VBJ-Lk; Thu, 13 Jul 2023 13:34:30 +0300 Date: Thu, 13 Jul 2023 13:30:08 +0300 To: Sergey Bronnikov Message-ID: References: <20230710155624.70639-1-max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9B2A9E02D3479B2E0309AC10CB7BBBE91EDDB935818B98891182A05F53808504041610F4DCC78FA7D67E945B7EC3C05156141B548D5F3085AE91489FC1C15928A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72F22E6DC541F75D9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063799A9E55CA76E18AB8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D816B123A51FA4157DD3DF82837FF30C29117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520C24E1E72F37C03A0618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE0AC5B80A05675ACD9100238FE36DC7A2D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3F8BD4E506CFA3D886136E347CC761E07C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947C1D471462564A2E192E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F83C798A30B85E16BC6EABA9B74D0DA47B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A50AE1852FA3E75679121EAAC3941A2AE0C623993B586494C1F87CCE6106E1FC07E67D4AC08A07B9B0CE135D2742255B35CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34ADE558D2B396DA7C599E6BBA91A8245277BA97B0595B71B2A2F12AD426E5B4C996AD4DECB28C7CF91D7E09C32AA3244C8EFBF4BC22A53D2EBEAF960D4E84A47F259227199D06760ABAD658CF5C8AB4025DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojmIyQFW4pVcnOBC2z001Cew== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769477CB02DCECECF0A67E945B7EC3C05151AB5AE572836FD89DEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] FFI: Fix recording of union initialization. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: Maksim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maksim! Thanks for the patch! LGTM, after fixing the Sergey's comment regarding the test description. On 13.07.23, Sergey Bronnikov wrote: > Hi, Max! > > > thanks for the patch! > > See my comments inline. > > > Sergey > > On 7/10/23 18:56, Maksim Kokryashkin wrote: > > From: Mike Pall > > > > Thanks to Alex Shpilkin. > > > > +for i = 1, NITERATIONS do > > + test:ok(union_type(i).u == i) > testcases description is missed, please add one. > > +end > > + > > +os.exit(test:check() and 0 or 1) -- Best regards, Sergey Kaplun