From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4B0F24CC570; Wed, 28 Jun 2023 14:40:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4B0F24CC570 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1687952450; bh=qKsLsl7xARlbxWO1b7bJNK75qdw8BW7d28cPfBUhzDk=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Y+q6JuxJ4Q69sYjfFsgSkkhlZ/WolEnRutLDPwIAyYt+qxBoEqF4XsQcaFalRAD8H RnDHrY1jf1YHyiKb+fiiUgXpc7RMS9fDprYWF0d2H96E41vYNEDj5Tj5FAzZwenwsq 3zbF+sw1kmgUO8tvNc31H8VTeZu8zrE3ZBjd66/U= Received: from smtp16.i.mail.ru (smtp16.i.mail.ru [95.163.41.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D57CB4CC570 for ; Wed, 28 Jun 2023 14:40:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D57CB4CC570 Received: by smtp16.i.mail.ru with esmtpa (envelope-from ) id 1qETXT-007cqx-RG; Wed, 28 Jun 2023 14:40:48 +0300 Date: Wed, 28 Jun 2023 14:36:30 +0300 To: Igor Munkin Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD95D99986233CC4DDC3E973A3BAF94D2517B3ABD6B770C5CCB182A05F53808504013178808E1291E1491F90C7C778B082B0CFC387B7F99DA163F3DA472EFCFF962 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F6EE1C40B2E8BE15EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CDAF09D3682101918638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A3F51B54444CF0BC5AB4B8837FCA98FB117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735209647ADFADE5905B16FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE042285CD7A5C321F4DC33E588678F033D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3DA7BFA4571439BB2BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CFED8438A78DFE0A9E1DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3FB9365559B687AC835872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A50209A6973E50223662B117AE3929FC1A4D402F38A6E9DF14F87CCE6106E1FC07E67D4AC08A07B9B01F9513A7CA91E555CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF213CE8B1AA7DBD92392BA850C998EA7499A86F78BF6CC7371990BA4B0FA38820F61CD9246542D0C400E7A357E107337495AA711AB6BC59F0476FF9D51D6CB420A74DFFEFA5DC0E7F02C26D483E81D6BE5EF9655DD6DEA7D65774BB76CC95456EEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj1ET+iAiNOrynL3Vg+fbd1A== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A76998D976A33E2F730791F90C7C778B082B5AB84C5967107110DEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/3] test: split utils.lua into several modules X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! Yes, splitting of the testing utils sounds like a good idea, indeed! With these changes all code becomes more organized. The patch itself LGTM, except a few nits regarding the commit message. On 27.06.23, Igor Munkin wrote: > The next patch introduces a separate JIT-related module with convenient > utils for JIT engine testing. Considering this change it looks vital to > make a structured utils distributed module instead of "all in one" Lua > chunk. As a result the original utils.lua is split into the several Typo: s/As a result/As a result,/ > modules per subsystem to be tested (e.g. GC, frontend, profilers, etc.). > > Lazy loading of the introduced submodules allows to use this utils in > all test chunks regardless LuaJIT configuration (e.g. with JIT engine Typo: s/JIT engine/the JIT engine/ > disabled, without FFI support, etc) and do not spoil utils table with Typo: s/etc/etc./ > the excess helpers. > > Signed-off-by: Igor Munkin > --- > > Sergey, considering the changes you've made in the second patch, I > propose to finally split utils.lua into submodules that loads lazily. > I've pushed my commit on your branch prior to your patchset. If you have > some notes regarding this, please share them. Otherwise, I'll push this > into the LuaJIT long-term branches. > > > You can also find the trivial changes made within your commits below: > > ================================================================================ > > diff --git a/test/tarantool-tests/lj-981-folding-0.test.lua b/test/tarantool-tests/lj-981-folding-0.test.lua > index 64473ba3..d156f53d 100644 > --- a/test/tarantool-tests/lj-981-folding-0.test.lua > +++ b/test/tarantool-tests/lj-981-folding-0.test.lua > diff --git a/test/tarantool-tests/unit-jit-parse.test.lua b/test/tarantool-tests/unit-jit-parse.test.lua > index e9c0bb80..e4445bf4 100644 > --- a/test/tarantool-tests/unit-jit-parse.test.lua > +++ b/test/tarantool-tests/unit-jit-parse.test.lua > ================================================================================ > > test/tarantool-tests/CMakeLists.txt | 2 +- > .../bc-jit-unpatching.test.lua | 5 +- > .../fix-gc-setupvalue.test.lua | 4 +- > .../gh-4427-ffi-sandwich.test.lua | 2 +- > .../gh-5813-resolving-of-c-symbols.test.lua | 2 +- > ...-missed-carg1-in-bctsetr-fallback.test.lua | 2 +- > .../lj-351-print-tostring-number.test.lua | 2 +- > .../lj-586-debug-non-string-error.test.lua | 2 +- > .../lj-flush-on-trace.test.lua | 2 +- > .../misclib-getmetrics-lapi.test.lua | 2 +- > .../misclib-memprof-lapi.test.lua | 2 +- > .../misclib-sysprof-lapi.test.lua | 2 +- > test/tarantool-tests/utils.lua | 125 ------------------ > test/tarantool-tests/utils/exec.lua | 52 ++++++++ > test/tarantool-tests/utils/frontend.lua | 25 ++++ > test/tarantool-tests/utils/gc.lua | 33 +++++ > test/tarantool-tests/utils/init.lua | 7 + > test/tarantool-tests/utils/jit/const.lua | 8 ++ > test/tarantool-tests/utils/jit/init.lua | 7 + > test/tarantool-tests/utils/tools.lua | 15 +++ > 20 files changed, 162 insertions(+), 139 deletions(-) > delete mode 100644 test/tarantool-tests/utils.lua > create mode 100644 test/tarantool-tests/utils/exec.lua > create mode 100644 test/tarantool-tests/utils/frontend.lua > create mode 100644 test/tarantool-tests/utils/gc.lua > create mode 100644 test/tarantool-tests/utils/init.lua > create mode 100644 test/tarantool-tests/utils/jit/const.lua > create mode 100644 test/tarantool-tests/utils/jit/init.lua > create mode 100644 test/tarantool-tests/utils/tools.lua > > diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt > index 527905b6..14a98cf2 100644 > --- a/test/tarantool-tests/CMakeLists.txt > +++ b/test/tarantool-tests/CMakeLists.txt > @@ -75,7 +75,7 @@ add_subdirectory(lj-flush-on-trace) > # directory), so LUA_PATH need to be updated. > make_lua_path(LUA_PATH > PATHS > - ${CMAKE_CURRENT_SOURCE_DIR}/?.lua > + ${CMAKE_CURRENT_SOURCE_DIR}/?/init.lua Side note: see updates in the second mail. > ${PROJECT_SOURCE_DIR}/tools/?.lua > ${LUAJIT_SOURCE_DIR}/?.lua > ${LUAJIT_BINARY_DIR}/?.lua > diff --git a/test/tarantool-tests/bc-jit-unpatching.test.lua b/test/tarantool-tests/bc-jit-unpatching.test.lua > -- > 2.30.2 > -- Best regards, Sergey Kaplun