From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D6E5E4F0849; Wed, 28 Jun 2023 13:23:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D6E5E4F0849 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1687947822; bh=s54HPqrs5zdhDqoHeaHBYjhfGmsXaceNBARtd4SkTuc=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=GGf6mun4NqegWnhyn3bNCVIndxltKLszuw66V3Bi4ICCZQC5tQnZ9bcNfiToQZwpW K7iJcxV+KHt4WZ6YNMbaTsraMwwxQkesiIPJ1bJ922zTNWWVyll3StC8kv4ltQ8AqM qm/gSRepTKJwoXnExjApGVKXwVjaEDKcTpdeNXmI= Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [95.163.41.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 751D44A9681 for ; Wed, 28 Jun 2023 13:23:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 751D44A9681 Received: by smtp32.i.mail.ru with esmtpa (envelope-from ) id 1qESKp-00AcWl-P0; Wed, 28 Jun 2023 13:23:40 +0300 Date: Wed, 28 Jun 2023 13:19:22 +0300 To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <1687423856.141170953@f477.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1687423856.141170953@f477.i.mail.ru> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD95D99986233CC4DDC5AEB4EC32BED92855647CC035713E37A182A05F538085040279FC9B84A420ECE5590BD0DD9689B8D7E71A1D8EC42E4047AE397BF89D17033 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F2393C4755A27B53EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063790B55F3E386DB9B28638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8539447A3DA0AA0627F8D72D692A7377A117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735204B6963042765DA4BE5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE042285CD7A5C321F6E0066C2D8992A164AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C38A6EFC3CE370B017BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CFED8438A78DFE0A9E1DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3C74813BC7F81EC8435872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5350760874292CE0AAD9DD5B0C0146422043EFBFAB31D7CE1F87CCE6106E1FC07E67D4AC08A07B9B0DB8A315C1FF4794DBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFA4A9609DFF1100130D7C2397F12DF3137A0BE1501DB7B9CB335178AFB2C2983B0F85117B495E935B00E7A357E107337480A39601649A24D881C3CD22AF92905F40B08DDBC5CE87D002C26D483E81D6BE5EF9655DD6DEA7D65774BB76CC95456EEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj1ET+iAiNOryKz8JmSBsk5w== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769599E58CFF904D6675590BD0DD9689B8D9FD6E2B231121C05DEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] Fix use-def analysis for BC_VARG. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! Fixed your comment and force-pushed the branch. On 22.06.23, Maxim Kokryashkin wrote: > > Hi! > Thanks for the fixes! > LGTM, except for a single nit below. >   > >  > >>> > >>+-- Test file to demonstrate LuaJIT misbehaviour in use-def > >>> > >>+-- snapshot analysis for BC_VARG. > >>> > >>+-- See also https://github.com/LuaJIT/LuaJIT/issues/704 . > >>> > >>+local test = tap.test('lj-704-bc-varg-use-def'):skipcond({ > >>> > >>+ ['Test requires JIT enabled'] = not jit.status(), > >>> > >>+}) > >>> > >>+ > >>> > >>+test:plan(1) > >>> > >>+ > >>> > >>+-- XXX: we don't really need to store this builtins, but this is > >>> > >Typo: s/this/these/ > >>> > >>> Fixed, thanks! > >Typo: s/this is/this/ Fixed, thanks! > >>> > >-- > >Best regards, > >Maxim Kokryashkin > >  -- Best regards, Sergey Kaplun