From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 189C5503769; Fri, 9 Jun 2023 13:07:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 189C5503769 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1686305262; bh=c7bduF5eCEEriOsT+ucczQsYR+chG57uHdq5xODNdaI=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Uo7SOelL44rvB08DSNd1h0gasx4Y9jkMu+RGmwhijBfQjja2DsXlTFDHKTuOB9uNj nZ7htxraN3ZlnUouvIbFqMdyfrT/BL4iksKpCfVM+iJCMEGynThDkV+1qfEP0tEZCu ztYXea19FaSuyquaRvIihdz0CGx7cQftnktSCm2E= Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [95.163.41.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6EE95503769 for ; Fri, 9 Jun 2023 13:07:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6EE95503769 Received: by smtp45.i.mail.ru with esmtpa (envelope-from ) id 1q7Z1v-003aex-Ll; Fri, 09 Jun 2023 13:07:40 +0300 Date: Fri, 9 Jun 2023 13:03:27 +0300 To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org, Maxim Kokryashkin Message-ID: References: <20230531132806.216178-1-m.kokryashkin@tarantool.org> <1686142983.790793793@f123.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1686142983.790793793@f123.i.mail.ru> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD965EFE7F2AC62B27A812BF47AEC9B8FAAED21A3AE25A7C519182A05F538085040BBD07B637D18C66399BB98EBD6CC1E5028041FFF69203FFBC1FDF0ED790E1AB6 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70186A8DAAA7CBDB1EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063798FF8892961A0B3C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D87FFC538E09D821459C797A9249265B7B117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC55B19328CBC4F849A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735204B6963042765DA4BF04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE1B544F03EFBC4D57E0F2381F647739FAD8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE364A52DF3AE21010F6E0066C2D8992A16C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637C970FD8DF19C51D2EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A527F9F13670B84B8BF1980C12E6B6DD9FCE538322FCDC43D0F87CCE6106E1FC07E67D4AC08A07B9B0DB8A315C1FF4794DBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34E69981C39E7B068A91CD239E78CB58B0BAF16B9C58053EC2C28EDB1540FC13712ADA82C2FA6794F61D7E09C32AA3244C551E791694F782EDEE694C2E810C3F57250262A5EE9971B085A42E4C463514DC5DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojRLo8CqjALXg7LuENUJXUmQ== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A7692BD43DCA652F70A399BB98EBD6CC1E50FE5F7FEA15315F16DEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix memory probing allocator to check for valid end address, too. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the fixes! LGTM, just a few typos. On 07.06.23, Maxim Kokryashkin wrote: > > Hi! > Thanks for the review! >   > >  > >>Hi, Maxim! > >>Thanks for the patch! > >>The patch is LGTM except a few insiginificant nits below. > >> > >>But I'm wondering: can we examine a test case mentioned in the [1]? > >>I.e. create a really long trace, near the upper bound of the 2GB, so > >>its results become meaningless? You may take a look into > >> or > >> > >>for the inspiration. > >> > >>This is desired to show actual problem, and not changes in some > >>synthetic behaviour. > >As we discussed offline, I’ve added the following comment, branch is force-pushed: > >============================================= > >+-- XXX: This test allocates `cdata` objects, but in real world > >+-- scenarios it can be any object that is allocated with > >+-- LuaJIT's allocator, including, for example, trace, if it > >+-- has been allocated close enough to the memory region > >+-- upper bound and if it is long enough. > >+-- > >+-- When this issue occurrs with a trace, it may lead to Typo: s/occurrs/occurs/ > >+-- failures in checks that rely on pointers being 32-bit. Typo: s/checks/the checks/ > >+-- For example, you can see one here: src/lj_asm_x86.h:370. > >+-- > >+-- Although it is nice to have a reproducer that shows how > >+-- that issue can affect a non-synthetic execution, it is really > >+-- hard to achieve the described situation with traces because > >+-- allocations are hint-based and there is no robust enough > >+-- way to create a deterministic test for this behavior. > >============================================= > >> > >>-- > >>Best regards, > >>Sergey Kaplun > >-- > >Best regards, > >Maxim Kokryashkin > >  -- Best regards, Sergey Kaplun