From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BC6CE503777; Fri, 9 Jun 2023 12:54:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BC6CE503777 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1686304491; bh=03gSeMLykgVCorQwKI1XFlFM2mFltICYoQqpVglA7ZE=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=KXDMnG5qADaUH3kmLNhf/tn+d2qTi975Ovl+UXwbLEhBlfAdCtBEDYtVGJzTm4BYY DGyTYJIY399Iee4zui52bRP/rV6/KBgkEGIox92gvJUt3T0yoaHmCQy7YefToM899m UXJvHctL5NfjQeRlSt1MuIy0aDv0Q0DmVC4cXixY= Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [95.163.41.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EE13E4DD270 for ; Fri, 9 Jun 2023 12:54:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EE13E4DD270 Received: by smtp31.i.mail.ru with esmtpa (envelope-from ) id 1q7YpW-00BAZM-AA; Fri, 09 Jun 2023 12:54:50 +0300 Date: Fri, 9 Jun 2023 12:50:39 +0300 To: Maxim Kokryashkin Message-ID: References: <20230609091358.1133736-1-m.kokryashkin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230609091358.1133736-1-m.kokryashkin@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD965EFE7F2AC62B27AB50C2688AE00CA8DA8B83115C249D799182A05F538085040C8863DF14DE4A60F0060F2A1E28F70C2F670A867F41C902C833C91E617C23918 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AED985C8E545F588EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063764345650F0BBEB0B8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D871BBAD24B878C28E18CB22C92C1B9A39117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC5F0C88D684269EDEA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520C65AC60A1F0286FECB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE0A3850AC1BE2E73507FB45A5F6E725C8D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3F8BD4E506CFA3D88AD7EC71F1DB88427C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637C970FD8DF19C51D2EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5B7835647BD6ABA31542CE632C0B10396DD20A8A2442D116DF87CCE6106E1FC07E67D4AC08A07B9B0DB8A315C1FF4794DBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3450C5E6D685282BA19042811D8076EC395CCBEFC719E29338F26009BADCBB4787F298DC9E326809131D7E09C32AA3244CEC32AE67BA7647F9A0199ECFC0C17915A90944CA99CF22E385A42E4C463514DC5DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojRLo8CqjALXi5f0VJw66Iuw== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769715D820D1B1288DB0060F2A1E28F70C27962F9E9328436E1DEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2] x64: Fix 64 bit shift code generation. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the fixes! About the patch itself: just 2 typos in the comments to the test. But I see [1] faliling tests on M1 with enabled JIT *. May be related to the [2]. Anyway, good to see, that test shows something :). *: I suggest to use `test:is()` instead of `test:ok()` to show `got` `expected` values. On 09.06.23, Maxim Kokryashkin wrote: > From: Mike Pall > + > +for i = 1, NITERATIONS do > + -- Rotation is performed beyond the 32-bit size, for truncation Typo: s/Rotation/The rotation/ > + -- to become noticeable. Sprintf is used to ensure that the > + -- result of rotation goes into the `rcx`, corresponing to Typo: s/corresponing/corresponding/ > + -- the x86_64 ABI. > -- > 2.40.1 > [1]: https://github.com/tarantool/luajit/actions/runs/5210890238/jobs/9402526109#step:7:907 [2]: https://github.com/tarantool/tarantool/issues/6097 -- Best regards, Sergey Kaplun