From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C3DC847DF0F; Mon, 29 May 2023 13:07:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C3DC847DF0F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1685354843; bh=gDInPSpBLhXSqB38Et6krmS+IfsILIFrMBfjoEgRVqo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=OWugyUGFSi2afWIiiApIn8Xi05HmzV2VefLe2clsrOjpCJ0dZW5it6Vhh2CODzc6t 5+L0lajh1uX6ZU3WAL3NtInITdUKaYQczxlKF655cbLoKaoETBbJvNarnVbF6+MpjI cO8KMSUnsorvRs5ptj/gddfDDXHKA4c8mEmT3cUU= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 792DC4427C8 for ; Mon, 29 May 2023 13:07:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 792DC4427C8 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1q3Zmb-0003GG-CJ; Mon, 29 May 2023 13:07:21 +0300 Date: Mon, 29 May 2023 13:03:14 +0300 To: Sergey Bronnikov Message-ID: References: <4564f805b390388473afa982db5cf3235f1cbaad.1684442182.git.skaplun@tarantool.org> <467c6552-2cc8-7097-6d86-bb8c9628bb84@tarantool.org> <1be152d0-9c74-0751-2473-2211ed32d625@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1be152d0-9c74-0751-2473-2211ed32d625@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9FA9FE7958A526B77309F3D27DFA702EA70EC4E5C3BB5181100894C459B0CD1B949DE9B88CB47D1457B79103441C9D7636405CB2A9666366377626B0F71EFE3B5 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76AB1B6FB25ACEDC9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376EC5B14D896A2D978638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8260E61B6E270374F12FE6CFD3127CDFC117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA1C5B227563B4AFA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520CCD848CCB6FE560C6FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A45692FFBBD75A6A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5BA66F78E962ADCEADCF94E6F9A86B4C12A6A4A45D15CB6B8F87CCE6106E1FC07E67D4AC08A07B9B01F9513A7CA91E555CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D349379E7F8541B6C9A977FDC6EF3612B2B5A658AA390F48FACA7B5B605A47AD19C56F23698C46293BB1D7E09C32AA3244C80CB7DE84C820DAA57895640DCF6F81EB4DF56057A86259F927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojjwJ7vqadnRvTgEawW3Oc2Q== X-DA7885C5: D17C6511D38D8A41791990FCC5CCF582D88C126BF4B1EB485E1C8614D7BDC511262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986BC72977B091FB99DB64EE2371C4436FAB0FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 2/6] test: introduce module for C tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comments and force-pushed the branch. On 25.05.23, Sergey Bronnikov wrote: > Hi, Sergey! Thanks for fixes, see comments below. > > On 5/24/23 09:41, Sergey Kaplun wrote: > > Hi, Sergey! > > Thanks for the review! > > > > Fixed some of your comments, branch is force-pushed. > > > > > The module serves to achieve these goals without too fancy > > features. > > > > It's functionality inspired by cmoka API [1], but only TAP14 [2] > >> typo: cmocka > > Fixed, thanks! > > > Nit: probably it is better "CMocka", because it is a proper name ("имя > собственное") and should be with capital letters. > > Feel free to ignore. Fixed! Thanks! > > > > >>> protocol is supported (Version of TAP set to 13 to be compatible with > >>> old TAP13 harnesses). > >> Please add tests for TAP13/TAP14 conformance testing. > >> > >> It would be unpleasant if proposed library will produce TAP-incompatible > >> output and it will break parsing in 'prove'. > >> > >> At least single test for passed testcase "ok", single testcase for > >> failed "not ok" testcase, one testcase for every directive. > > I've added the tests for ok|skip|todo. "not ok" is skipped, because it > > rather tricky to test it behaviour via prove without test failure. > > > > The content of is the > > following: > > =================================================================== > > =================================================================== > > This test checks that macroses/functions in test.h could be called and > nothing more. > > We need checking TAP output that binary will emit for different test > statuses, plan, testcase counters ("1..10"). As discussed offline: its not the main goal of this suite introducing, also, TAP13 protocol is tested by `prove` itself, and fully compatible with TAP14 protocol. Also, added the following check of parsing to be sure in the emmited format correctness. =================================================================== diff --git a/test/tarantool-c-tests/CMakeLists.txt b/test/tarantool-c-tests/CMakeLists.txt index bf98856f..1aade851 100644 --- a/test/tarantool-c-tests/CMakeLists.txt +++ b/test/tarantool-c-tests/CMakeLists.txt @@ -36,6 +36,9 @@ add_custom_command(TARGET tarantool-c-tests ${CMAKE_CURRENT_BINARY_DIR} --ext ${C_TEST_SUFFIX} --jobs ${CMAKE_BUILD_PARALLEL_LEVEL} + # Reportt any TAP parse errors, if any, since test module is + # maintained by us. + --parse ${C_TEST_FLAGS} WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} =================================================================== Also, mentioned this in the commit message: | The library itself is tested via some primitive tests for `ok` case, | `skip` and `todo` directives. The TAP13 format is tested via prove, that | we are using for running our tests. TAP14 format is compatible with | TAP13, so there are no other tests required. -- Best regards, Sergey Kaplun