From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 12D334405A1; Tue, 6 Jun 2023 15:59:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 12D334405A1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1686056379; bh=nNh86k8NG/F7nPIMZVsaamJt9bJLA3jA+VVQM7kHNec=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=gW5/P1NptcgjNq2YBpwephuJvbcfMMxyXdYe0YkG5yp2YAA+f5kyF6lE4DwG+t4vZ RF2k5uI/gG+CASUz8NkoVPCcgVYLWaCMPmYt3hkLY6ONNue8bMNB7MJlTyRYfoxs0+ qHN8gxdkboPjcgf5wMmknhmhTkaU3UgkFHP4thl4= Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [95.163.41.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 88F734405A1 for ; Tue, 6 Jun 2023 15:59:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 88F734405A1 Received: by smtp36.i.mail.ru with esmtpa (envelope-from ) id 1q6WHg-004suK-RH; Tue, 06 Jun 2023 15:59:37 +0300 Date: Tue, 6 Jun 2023 15:55:26 +0300 To: Sergey Bronnikov Message-ID: References: <7be88fa24695ad2f3c15a9a23bd884ca0acc36f5.1685433737.git.sergeyb@tarantool.org> <1685437504.620113247@f480.i.mail.ru> <8e60e454-de80-e532-ee1d-ad771956ab16@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8e60e454-de80-e532-ee1d-ad771956ab16@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD93D74B10BAB639DE3EBF0968330660A230375250DECE8466F00894C459B0CD1B9529E95B4691493D64C0AC9E5D4D5CE69B46696C49472843D954A11D17F55FE80 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE764C944B6AA401A18EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378BCFB34D7DDF138E8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D85A83D9FC070B81E416AD1BFEFD905BD0117882F44604297287769387670735200AC5B80A05675ACD6FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE042285CD7A5C321F9100238FE36DC7A2D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3F8BD4E506CFA3D88C0837EA9F3D19764C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637B8F435DEDE9E76EBEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A53115B0DE8DBF711C255E5B52CA1ADE352065F259745C31D4F87CCE6106E1FC07E67D4AC08A07B9B0CE135D2742255B35CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D347215713CF3EEE9D1F70C6BBD5171BF6AE480532547ADF80DD4B8FC9125B7598B8898E80CE05D6F781D7E09C32AA3244CC25439F98F7A7745E4307C3DD7C47A0C3A92A9747B6CC886BAD658CF5C8AB4025DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojBFnFgsoZgk7lLtFxg4rvQA== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769E689FA71D31599290AF483E4657C40D5228AB1844EA588C7DEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2 1/1] Fix saved bytecode encapsulated in ELF objects. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: Sergey Bronnikov , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim, Sergey! Thanks for the comments! On 31.05.23, Sergey Bronnikov wrote: > Hello, Max! Thanks for comments! > > Fixed all comments except checks for constant size and offset, fixes > force-pushed. > > > Sergey > > On 5/30/23 12:05, Maxim Kokryashkin wrote: > > Hi, Sergey! > > Thanks for the patch! > > LGTM, except for a few comments below. > > + > > +test:is(strtab_size, expected_strtab_size, 'check .strtab size') > > +test:is(strtab_offset, expected_strtab_offset, 'check .strtab > > offset') > > > > As I already said offline, I don’t like that approach. ELF is made > > to by > > as flexible as possible, so, generally, you have no guarantees about > > order and, hence, offsets of any sections. The only reason why we are > > getting away with that here, is because this ELF is generated > > in `bcsave.lua` in a particular manner. It is ok for now, but no one > > knows if this will ever change. I think that the symbol name search > > below is sufficient, because it is unlikely to pass with an > > incorrect offset. But, the finding the symbol, doesn't guarantee the correct offset emitting. I suggest to leave double check here, too, as well as Sergey. Also, we can track the changes in better:). > > > Sure, I remember your thoughts regarding checking with constant size and > offset. > > I left this for double-checking change proposed in patch. > > I'll leave this as as without changes and will wait review from Sergey > > and then we will decide remove these checks or not. > > > All of the checks are valid for now, though, so feel free to ignore. > > -- > > Best regards, > > Maxim Kokryashkin > > -- Best regards, Sergey Kaplun