From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2F63045B1E2; Sun, 21 May 2023 10:51:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2F63045B1E2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1684655486; bh=GpC+7qeE1pT0FDpdwjJLGVTIE80sv2IGXi8J+ZxZ0Go=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=fma6HmOHiVSvwbi3cghPImydwdqqGKDE/fnXuYPnr6MwhVuh0iWJzBn460DLushpr Iqnx6fsEIcvbH4+uwavjnlvoGJQx4/pne7i9yt+9FkF0QTRAz7lX7fyptowFf+V1GH thjnJX+JQIVY7/XoN+zbhd/2SNPJrzoE6z5lk5X0= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 24EBE45B1D9 for ; Sun, 21 May 2023 10:51:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 24EBE45B1D9 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1q0dqe-0001gs-BJ; Sun, 21 May 2023 10:51:24 +0300 Date: Sun, 21 May 2023 10:47:19 +0300 To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <44354d682d3cabf5a3ab1a268f900d7e6f981020.1683720396.git.skaplun@tarantool.org> <1684149117.34095260@f521.i.mail.ru> <1684152027.960158690@f170.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1684152027.960158690@f170.i.mail.ru> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD921E8753A900160F1284B0F69140CBAD1A760B8050B399C32182A05F53808504038A930FC77D6D67A4B83F9EA755E1A229D0E64D7CA951FE41B63AF0B64EA40B8 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70A10A23A3B64B805EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637645995A778B1BFFAEA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BE5CCB53A13BC8DBACA6C672B04B284F3298DE379D31F214ECC7F00164DA146DAFE8445B8C89999728AA50765F7900637B936CAE925EBC817389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC84B6F6234D9065C97F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B9F5955FECEF5819E75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5F29A3DF068A6D5A5FFCC6CC49F8FE6DC3458309A1C77B151F87CCE6106E1FC07E67D4AC08A07B9B0DB8A315C1FF4794DBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34C53592357E8057733BE89DC54145EB63AEE0BAB67ABB25137566649947866BA533A3204D2F9B9BB91D7E09C32AA3244C5CD97BBC564C8F99ACE3B4FF57798FB1B4DF56057A86259F729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj5fgIvaFza06IyihzYh98GA== X-DA7885C5: E7B2C1178486C0EEFCD583C9D510EE28D49F330A4781810C4C96DB96DE885A86262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B7D9396E199AD56476501916CCF988D370FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] test: add utility for parsing `jit.dump` X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, again! :) On 15.05.23, Maxim Kokryashkin wrote: > > Hi again! > It seems like I keep forgetting a single nit in every > review today. >   > I am concerned about the `test/tarantool-tests/utils/jit_parse.lua` > path, since we already have the `test/tarantool-tests/utils.lua` > module. I think we should rename this directory to `tools` or > something like that. Actually, this was done by intention to accent that this is part of our utils for testing (it may be considered as a submodule). > -- > Best regards, > Maxim Kokryashkin >   >   > >>>2.34.1 > >>-- > >>Best regards, > >>Maxim Kokryashkin > >>  >   -- Best regards, Sergey Kaplun