From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 80F1E6FCB3; Sat, 20 May 2023 10:32:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 80F1E6FCB3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1684567968; bh=qiOxTWz/oBUs7KXkIoytMSh7W9QKmSY63PWT3XDnKXU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=S67szLrhMnzqdm4M9RWvE2R8yN7e9Ac0RSwvZDlPFoiU5e/njcm5fIblSua7xNV28 EQ7S2WlWKZnUYGsjY2D3M3AFmlcJyhqTnsMDr7AIzVHza7Azpp8kElFnfeGDj+a4CS DB+gEjWDpUtnxQ+2+oTObouXYFfBKGRZQLGnEvRY= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 69F2D6FCB3 for ; Sat, 20 May 2023 10:32:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 69F2D6FCB3 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1q0H53-0005QH-Cq; Sat, 20 May 2023 10:32:45 +0300 Date: Sat, 20 May 2023 10:28:41 +0300 To: Maxim Kokryashkin Message-ID: References: <14b188edc970d9e8933c392a2fabd5ad412653e1.1684442182.git.skaplun@tarantool.org> <1684501221.951685952@f310.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1684501221.951685952@f310.i.mail.ru> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD921E8753A900160F1507DF79122D2C682EA3C9549AE366905182A05F5380850407FA6A10F6EA39FD9BC35DD94F506E4BE0E38626F60D676C2DDA4EBEB9A524A2A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7227E4400968B082FEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063781BF90BB6B3E56078638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C936A098D023A135C5F25B92537FD528117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF80095D1ED7F4578A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735204B6963042765DA4BE5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6AC294AFEFA671E80089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5A159E838482852DAC4C319B6358A8570B33902A34E4AB361F87CCE6106E1FC07E67D4AC08A07B9B0CE135D2742255B35CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3416EA6E382A5BB176A4CA9F6566B06A396DA4432EF96476A00246D778E1837A0627CB4FC419563CE61D7E09C32AA3244CB364306A250AC8B766DC50371E997011435BF7150578642F927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojlaZ30BpkxfIbPWe87bJSMg== X-DA7885C5: 252B319D54E1D1EF25DCBDDF8018F6481C7B86390D91BA4A68C841AD9B9B585A262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B2D7E09034B9226721358B71E463C6C8C0FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 5/6] test: rewrite misclib-sysprof-capi test in C X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! On 19.05.23, Maxim Kokryashkin wrote: > > Hi, Sergey! > Thanks for the patch! > LGTM, except for two questions below. >   > >  > >>+ > >>+ lua_pushcfunction(L, c_payload); > >>+ lua_setfield(L, LUA_GLOBALSINDEX, "c_payload"); > >Is there a cleaner approach? I suppose no. I think that set the global value is the simpliest way for this test. > >>+ utils_load_aux_script(L); > >>+ > >>+ const struct test_unit tgroup[] = { > >>+ test_unit_new(base), > >>+ test_unit_new(validation), > >>+ test_unit_new(profile_func_jitoff), > >>+ test_unit_new(profile_func_jiton) > >Maybe we shouldn’t put these tests into group as long as they are disabled? We still may skip them via TODO directive, so let them as is in the output. I'll wait for the 2nd review opinion and either use `#if 0` for comment or double return. > >>+ }; > >>+ const int test_result = test_run_group(tgroup, L); > >>+ utils_lua_close(L); > >>+ return test_result; > >>+} > >> > >-- > >Best regards, > >Maxim Kokryashkin > >  -- Best regards, Sergey Kaplun