From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A4E304695D7; Wed, 24 May 2023 09:13:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A4E304695D7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1684908801; bh=jiNZyLfexwcl3DqC+jRu9KUjhMs5wTtEVkoBg7RtKO8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=V2DZyyXf3yNAAasygPNzbcrCHU9tQmRD9dIthCHClh8j9Pu+yLiA7yQ24SG7UMOoV e+L+nnFpA+vE5fhc+OZ12Z/zQWfE3SfmaajF3ucBgZd2NVRzbyGvBNakv7NC83IHV7 fnEchiNR0shvqC5bX94UZskIFOY7rk/6VGm91JVE= Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [95.163.41.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A3C964695D7 for ; Wed, 24 May 2023 09:12:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A3C964695D7 Received: by smtp39.i.mail.ru with esmtpa (envelope-from ) id 1q1hjt-003N3H-El; Wed, 24 May 2023 09:12:49 +0300 Date: Wed, 24 May 2023 06:10:04 +0000 To: Maksim Kokryashkin Message-ID: References: <20230515091622.30232-1-max.kokryashkin@gmail.com> <20230515091622.30232-4-max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230515091622.30232-4-max.kokryashkin@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9318AAE2601AA39B88BEC2C1F8446F92CD9252AF2740821E800894C459B0CD1B9017B323DA0959931DCB980B6BE0FB344EACB1E0530CB486C02A17C04448FB737 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F65C230EDDCD559EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063790C8302959DAAF098638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D84114FDCA92EF89A022992CC50A492BA1117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCD6672DD12D5A8206A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520C1DE5D12A4F17E62CB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE902A1BE408319B29846F39228950D27DD8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE367F1C1C3ABB44F3A040F9FF01DFDA4A8C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637BF1C901A33650803EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A512AABA8A66B51D2DBFA3AEF9EB22DE967827CF39318CC6D2F87CCE6106E1FC07E67D4AC08A07B9B0CE135D2742255B35CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D343F22CE0A71FDB37EC1E13910989F6F19522EA5039FB3EE0E2FEBE37FDDE969F1F373E41014FF24991D7E09C32AA3244CC8E301CE8B45C7FF4558B39968C7A9FB250262A5EE9971B08D5DD81C2BAB7D1D X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj7RK+RruQK1difSM5LbJZJQ== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D531C15EC91AC9D6FC8F9652C4FA060D1017700A3768C86869552326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v4 3/4] OSX: Disable unreliable assertion for external frame unwinding. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the patch! LGTM with a single nit below. On 15.05.23, Maksim Kokryashkin wrote: > From: Mike Pall > > (cherry-picked from commit be251d9149b386ca0d4b51106be14366c5dbdf14) > > `_Unwind_Find_FDE()` will locate the FDE if the pc is in some > function that has an associated FDE. Note, Mac OS X 10.6 and > later, introduces "compact unwind info" which the runtime uses in > preference to DWARF unwind info. This function will only work if > the target function has an FDE but no compact unwind info. > The LuaJIT VM produces compact unwind info entries, so AFAIR, compact unwind info is generated only for machasm, isn't it? I suggest to mention this explicitly in the commit message. > DWARF's FDE is not found and that assertion fails. > > Maxim Kokryashkin: > * added the description for the problem > > Part of tarantool/tarantool#7745 > Part of tarantool/tarantool#8069 > --- > src/lj_err.c | 3 +++ > 1 file changed, 3 insertions(+) > -- > 2.39.2 (Apple Git-143) > -- Best regards, IM