From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E5D584195A5; Wed, 3 May 2023 11:44:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E5D584195A5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1683103442; bh=4Nw98QPbJy8v28omThw5O9WkoootPdMuWAHsVwio5y4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=vd4TrKQvy1gWWOJ6fcqiiZUk5fKbp8yQD3CfDbKEeZN6XleRjmFajAl1jUy5Gy5p3 ESKM3gVW/AZDvArjp6YHvk8REZcR1AOGUaVJBJA6oe47n0TPcvH5jCQqAsrLutT5yo 2s1+LV2loD3AeubwrMSV9qA592/uBMfx3e70V/bg= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 396A84195A5 for ; Wed, 3 May 2023 11:44:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 396A84195A5 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1pu85g-0006eI-AV; Wed, 03 May 2023 11:44:00 +0300 Date: Wed, 3 May 2023 11:40:01 +0300 To: sergos Message-ID: References: <20230411203650.10125-1-skaplun@tarantool.org> <1681835638.341302219@f402.i.mail.ru> <91DEE028-B10D-4B36-BBE2-FF18CE9AD514@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <91DEE028-B10D-4B36-BBE2-FF18CE9AD514@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9F572AEF33F1BC585282B95A99157D032FB41EDBBF23D2E37182A05F5380850401DD15CCCF6BD3F59D6019520B99F38D6537CC874C7E0D12680C5B8D1AD860E6D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE747D938A1F6F567D4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637889C00975665ABF68638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D815BFC41FE1A402318720276AEC865064117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC317C7E487E00003AA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735204B6963042765DA4BF04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6300D3B61E77C8D3B089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A53575D9EA078B3B23CF95D8BA9DE466FAF8B4BB2303E7E9FAF87CCE6106E1FC07E67D4AC08A07B9B0CE135D2742255B35CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34C264B329661203DA1FABF317AB4A57289E1DCDD4DBC5D088BA31419D9F9739D8A076E066B5232EC51D7E09C32AA3244CAB89A8729EDF835C2AB85FCF50C1347EF2F5F14F68F1805BFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojtUGOBMG7VVMW1dcOgtoFUA== X-DA7885C5: AD4FB01FDEEB7A15C9D0420CF945380F16BABF2124DF87895DDBDDE242B84117262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73933AF1F914F131DBF5E2795493B24BCB7C0155961A482BE0290FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] LJ_GC64: Make ASMREF_L references 64 bit. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergos! Thanks for the review! On 03.05.23, sergos wrote: > Hi! > > Thanks for the patch! > > Since test is x86_64 only - can we put an explicit skipcond then? We have two sides of the same coin here: There is no bug for arm64, but some source code for this IR still exists. Yes, we don't see any influence of the patch on arm64. But, OTOH, we sure that there will be no regression in the future. As far as changed code in the patch is platform independent, I prefer to avoid skipcond here. So, ignoring for now. > > Otherwise LGTM. > > Sergos. > > -- Best regards, Sergey Kaplun