From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B7D423FDAD3; Thu, 30 Mar 2023 20:46:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B7D423FDAD3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1680198391; bh=vdVqx0GJri2Jd+QbQn3d6lXBcgQwSaVG0DqAz+EtU/g=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=avzHxPxhmtYyCLWhPobMQlg3Oacj9f1gRAJcDwZKAdE/LjV54tzxc58/uiQ0UTyXc XmLuhHoqkCDQk0JJ4wFstByeXLwcp0qPHM3wngOGqSAN3vcRJvvuc6ybyrj6Ky7YYb OTrYWeNV8j1I5LdsZLJxY+TaTpHk5Qj/ryvXRFMs= Received: from smtp42.i.mail.ru (smtp42.i.mail.ru [95.163.41.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 057993FDAD6 for ; Thu, 30 Mar 2023 20:46:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 057993FDAD6 Received: by smtp42.i.mail.ru with esmtpa (envelope-from ) id 1phwLe-00BV2f-Sy; Thu, 30 Mar 2023 20:46:07 +0300 Date: Thu, 30 Mar 2023 17:38:51 +0000 To: Sergey Kaplun Message-ID: References: <20230210130146.30703-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230210130146.30703-1-skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9381BDEF7E8905223C2571AC359025324CD60E11B6678EC3C182A05F5380850407F9EE0E73C81DF405BF7BCADB14B3C39E58FB6BA6B2D1E25CB9F2F372B37B3DB X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DECE8D0A5E25C0FCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375FE8AD9F0D2764EB8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8EFDBBF0B7F26580F4E888F59B98E8A76117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC0F49EF363AAD6E82A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735200AC5B80A05675ACDBDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE38D4DC57D478E688A5FD2DD08EB4836CD8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3F8BD4E506CFA3D882D242C3BD2E3F4C6C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006377F02F59195295693EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5E8DEC85D5260A13C9EA7C1843213EA464AC914ACE363F4E6F87CCE6106E1FC07E67D4AC08A07B9B062B3BD3CC35DA588CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34D6AC337C1E637B8A57B1CFC2352966D9F5E54120B3799BAD3F1A57B25AA4B5C58D947415EA8741581D7E09C32AA3244CA8E3F905EC6331717A407080B69F69A8D08D48398F32B4A6927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiHgmeVjUOtKzovPvFkCuKg== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D531DD6514AB886B782AB42B4301ACCD3AB2520D52D5CF215F1E2326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] ARM64: Fix pcall() error case. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, 2.11 and 2.10. On 10.02.23, Sergey Kaplun via Tarantool-patches wrote: > From: Mike Pall > > Reported by Alex Orlenko. > > (cherry picked from commit b4b2dce9fc3ffaaaede39b36d06415311e2aa516) > > The `pcall()` assembler preambule modifies `RC` (`x28`) (N args * 8) > during the check of the amount of the given arguments. So, this wrong > value using in the `fff_fallback` routine leading to a crash on the > error throwing, because the Lua stack is filled incorrect and can't be > unwound. > > This patch adds the additional comparison before taking the fallback > branch and modifies `RC` only after this branch. > > Sergey Kaplun: > * added the description and the test for the problem > > Part of tarantool/tarantool#8069 > --- > > PR: https://github.com/tarantool/tarantool/pull/8295 > Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-762-arm64-pcall-no-arg > Issues: > * https://github.com/tarantool/tarantool/issues/8069 > * https://github.com/LuaJIT/LuaJIT/issues/762 > > src/vm_arm64.dasc | 3 ++- > test/tarantool-tests/lj-762-pcall-no-arg.test.lua | 15 +++++++++++++++ > 2 files changed, 17 insertions(+), 1 deletion(-) > create mode 100644 test/tarantool-tests/lj-762-pcall-no-arg.test.lua > > -- > 2.34.1 > -- Best regards, IM