From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A71C9215DEA; Thu, 30 Mar 2023 20:44:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A71C9215DEA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1680198270; bh=wCtZP/FoL5c3kPwz7dOWEA4iJ80wTB/6RabuBXCMV9c=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=xkvvlj/dfH6BKdeaiQzPEXI6L4kL4Ly/Oqw+bIo0JgqbppsR+UCnNmozQ29T1Hcmp w28SbQXpyFboaRuCFfYkHfPZnO+BrtlLy/GIxm0P64hHWFND5PC/apr4Fai4zcRuOW tP21fZLfej/EBB1bJbF5FPzCUUyB8vRH17ya+mAE= Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [95.163.41.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 96353215DEA for ; Thu, 30 Mar 2023 20:44:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 96353215DEA Received: by smtp31.i.mail.ru with esmtpa (envelope-from ) id 1phwK4-00BsvE-NP; Thu, 30 Mar 2023 20:44:29 +0300 Date: Thu, 30 Mar 2023 17:37:13 +0000 To: Sergey Kaplun Message-ID: References: <20230125185758.5760-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230125185758.5760-1-skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9F8F06A4ADC2A029ED392DF46D9BBD91993351BDDA8FBAA571313CFAB8367EF908E2BE116634AD74D87DE311DF34C98B115C68702E5CDBB1C61083FF6DCA8A415AF77107535B39722 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72F22E6DC541F75D9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374F960C921106F05B8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D83C4A9ADEFC536631C4887FB5C429B40A117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC00E8CE3DD197987DA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735200AC5B80A05675ACDF04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EED76C6ED7039589DE7F16001415B11694D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE367F1C1C3ABB44F3A6E0066C2D8992A16C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F790063747074E5DE1517656EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A55062DBBB873E474B8972248B5711FBD497DD0E2E2372F5A9F87CCE6106E1FC07E67D4AC08A07B9B01DAA61796BF5227BCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34D041FB2E16F174C494CC53A457AA3A75C846C98D7E854EC7D4A2B744038B68B9877DA34EF30F2FF91D7E09C32AA3244CCB9D7863B78E9D02C946A7E629EA3AC151E887DA02A9F7BF927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiHgmeVjUOtJ2JpAVmKL+vQ== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D53155CFAF2723FD49F9A79C587BF55B797684E6363C6D3D46772326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] ARM64: Fix {AHUV}LOAD specialized to nil/false/true. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, 2.11 and 2.10. On 25.01.23, Sergey Kaplun via Tarantool-patches wrote: > From: Mike Pall > > Reported by caohongqing. > > (cherry picked from commit 5bf0da3d7c02f9959fa3a9fb721e0565137b70c8) > > If there is high register pressure, and there are almost all registers > in use during the aforementioned assembling, the same register is chosen > as the one holding the given stack slot and the one holding the constant > value for the type comparison. As the result we get the following > assertion guard check in assembly: > | cmp x0, x0, lsr #32 > | bne ->0 > Which is always false. > > This happens because the `tmp` register (used for loading constant type > to compare in assertion guard) is scratched from `gpr` register set, but > not from `allow` set, which is used during picking the register for slot > loading (at the begging `allow` and `gpr` sets are the same). > > This patch changes `allow` set to `gpr` to fix the issue. > > Sergey Kaplun: > * added the description and the test for the problem > > Part of tarantool/tarantool#8069 > --- > > Branch: https://github.com/tarantool/luajit/tree/skaplun/or-94-fix-bool-ahuvload > PR: https://github.com/tarantool/tarantool/pull/8214 > Issues: > * https://github.com/tarantool/tarantool/issues/8069 > * https://github.com/openresty/luajit2/pull/94 > > src/lj_asm_arm64.h | 2 +- > .../or-94-arm64-ir-ahuvload-bool.test.lua | 145 ++++++++++++++++++ > 2 files changed, 146 insertions(+), 1 deletion(-) > create mode 100644 test/tarantool-tests/or-94-arm64-ir-ahuvload-bool.test.lua > > -- > 2.34.1 > -- Best regards, IM